Skip to content

Commit 7bcd0d4

Browse files
committed
Restored tests
1 parent 7094abc commit 7bcd0d4

File tree

4 files changed

+31
-18
lines changed

4 files changed

+31
-18
lines changed

Diff for: src/AngleSharp.Io.Tests/Cookie/ClassicTests.cs

+6-5
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ public async Task SettingThreeCookiesInOneRequestAreTransportedToNextRequest()
251251
""test"": ""baz""
252252
}
253253
}
254-
".Replace(Environment.NewLine, "\n");
254+
".Replace("\r\n", "\n");
255255

256256
Assert.AreEqual(expected, document.Body.TextContent);
257257
}
@@ -275,7 +275,7 @@ public async Task SettingCookieIsPreservedViaRedirect()
275275
""test"": ""baz""
276276
}
277277
}
278-
".Replace(Environment.NewLine, "\n"), document.Body.TextContent);
278+
".Replace("\r\n", "\n"), document.Body.TextContent);
279279
}
280280
}
281281

@@ -429,13 +429,14 @@ public void ShouldChangeSelectedCookiesOnRedirect_Issue548()
429429
var mcp = new MemoryCookieProvider();
430430
var config = Configuration.Default.With(mcp).With(requester).WithDefaultLoader();
431431
var context = BrowsingContext.New(config);
432-
var receivedCookieHeader = "THECOOKIE=value1";
432+
var setCookie = "THECOOKIE=value1";
433+
var receivedCookieHeader = "";
433434
var url = new Url("http://example.com/path1");
434435
//request 1: /path1, set a cookie THECOOKIE=value1
435436
requester.BuildResponse(req => VirtualResponse.Create(r => r
436437
.Address("http://example.com/path1")
437438
.Content("")
438-
.Header(HeaderNames.SetCookie, receivedCookieHeader)));
439+
.Header(HeaderNames.SetCookie, setCookie)));
439440
context.OpenAsync("http://example.com/path1");
440441
//request 2: /path1/somefile.jsp redirects to /path2/file2.jsp
441442
requester.BuildResponses(new Func<Request, IResponse>[] {
@@ -452,7 +453,7 @@ public void ShouldChangeSelectedCookiesOnRedirect_Issue548()
452453
}
453454
});
454455
context.OpenAsync("http://example.com/path1/somefile.jsp");
455-
Assert.AreEqual(String.Empty, receivedCookieHeader);
456+
Assert.AreEqual(setCookie, receivedCookieHeader);
456457
}
457458

458459
private static Task<IDocument> LoadDocumentWithFakeRequesterAndCookie(IResponse initialResponse,

Diff for: src/AngleSharp.Io.Tests/Network/CookieHandlingTests.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public async Task SettingThreeCookiesInOneRequestAreTransportedToNextRequest()
7070
""test"": ""baz""
7171
}
7272
}
73-
".Replace(Environment.NewLine, "\n"), document.Body.TextContent);
73+
".Replace("\r\n", "\n"), document.Body.TextContent);
7474
}
7575
}
7676

@@ -92,7 +92,7 @@ public async Task SettingCookieIsPreservedViaRedirect()
9292
""test"": ""baz""
9393
}
9494
}
95-
".Replace(Environment.NewLine, "\n"), document.Body.TextContent);
95+
".Replace("\r\n", "\n"), document.Body.TextContent);
9696
}
9797
}
9898

@@ -114,7 +114,7 @@ public async Task SettingCookieIsPreservedViaRedirectToDifferentProtocol()
114114
""test"": ""baz""
115115
}
116116
}
117-
".Replace(Environment.NewLine, "\n"), document.Body.TextContent);
117+
".Replace("\r\n", "\n"), document.Body.TextContent);
118118
}
119119
}
120120
}

Diff for: src/AngleSharp.Io.Tests/Network/HttpClientRequesterTests.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ public async Task ResponseWithContent()
7171
// ASSERT
7272
response.Address.Should().BeEquivalentTo(ts.Request.Address);
7373
response.StatusCode.Should().Be(ts.HttpResponseMessage.StatusCode);
74-
response.Headers.Keys.Should().BeEquivalentTo(new[] {"Server", "X-Powered-By", "X-CSV", "Content-Type"});
74+
response.Headers.Keys.Should().BeEquivalentTo(new[] {"Server", "X-Powered-By", "X-CSV", "Content-Type", "Content-Length"});
7575
response.Headers["Server"].Should().Be("Fake");
7676
response.Headers["X-Powered-By"].Should().Be("Magic");
7777
response.Headers["X-CSV"].Should().Be("foo, bar");
@@ -91,11 +91,11 @@ public async Task ResponseWithoutContent()
9191
// ASSERT
9292
response.Address.Should().BeEquivalentTo(ts.Request.Address);
9393
response.StatusCode.Should().Be(ts.HttpResponseMessage.StatusCode);
94-
response.Headers.Keys.Should().BeEquivalentTo(new[] {"Server", "X-Powered-By", "X-CSV"});
94+
response.Headers.Keys.Should().BeEquivalentTo(new[] {"Server", "X-Powered-By", "X-CSV", "Content-Length"});
9595
response.Headers["Server"].Should().Be("Fake");
9696
response.Headers["X-Powered-By"].Should().Be("Magic");
9797
response.Headers["X-CSV"].Should().Be("foo, bar");
98-
response.Content.Should().BeNull();
98+
new StreamReader(response.Content, Encoding.UTF8).ReadToEnd().Should().Be("");
9999
}
100100

101101
[Test]

Diff for: src/AngleSharp.Io.Tests/Network/WebSocketTests.cs

+19-7
Original file line numberDiff line numberDiff line change
@@ -21,25 +21,37 @@ public async Task ConnectToWebSocketEcho()
2121
var haserror = false;
2222
var messages = new List<String>();
2323
var closed = new TaskCompletionSource<Boolean>();
24-
var document = await BrowsingContext.New().OpenNewAsync("https://www.websocket.org/echo.html");
25-
var ws = new WebSocket(document.DefaultView, "ws://echo.websocket.org");
24+
var document = await BrowsingContext.New().OpenNewAsync("https://echo.websocket.events/.ws");
25+
var ws = new WebSocket(document.DefaultView, "wss://echo.websocket.events/");
2626

2727
// ACT
2828
ws.Opened += (s, ev) => ws.Send(message);
2929
ws.Message += (s, ev) =>
3030
{
3131
var msg = ev as MessageEvent;
3232
messages.Add(msg.Data.ToString());
33+
34+
if (messages.Count == 2)
35+
{
36+
ws.Close();
37+
}
38+
};
39+
ws.Closed += (s, ev) =>
40+
{
41+
closed.SetResult(true);
42+
};
43+
ws.Error += (s, ev) =>
44+
{
45+
haserror = true;
3346
ws.Close();
3447
};
35-
ws.Closed += (s, ev) => closed.SetResult(true);
36-
ws.Error += (s, ev) => haserror = true;
3748
await closed.Task;
38-
49+
3950
// ASSERT
4051
haserror.Should().BeFalse();
41-
messages.Count.Should().Be(1);
42-
messages[0].Should().Be(message);
52+
messages.Count.Should().Be(2);
53+
messages[0].Should().Be("echo.websocket.events sponsored by Lob.com");
54+
messages[1].Should().Be(message);
4355
}
4456
}
4557
}

0 commit comments

Comments
 (0)