Skip to content

Commit 403dfd5

Browse files
odmirKarthikRIyer
authored andcommitted
conf: Turn on quartz tests for annotations (#110)
* update almost all tests to use new `renderAndVerify` function turning on the quartz annotation tests that were previously off. * don't check if files are equal if any of them does not exist in the first place * add missing reference images for quartz
1 parent 0aa4f5e commit 403dfd5

34 files changed

+35
-482
lines changed

Tests/SwiftPlotTests/Annotation/annotation-arrow-dart.swift

+1-18
Original file line numberDiff line numberDiff line change
@@ -30,23 +30,6 @@ extension AnnotationTests {
3030
startAnnotation: Text(text: "relative maxima",
3131
direction: .west)))
3232

33-
let svg_renderer = SVGRenderer()
34-
try lineGraph.drawGraphAndOutput(fileName: svgOutputDirectory+fileName,
35-
renderer: svg_renderer)
36-
verifyImage(name: fileName, renderer: .svg)
37-
#if canImport(AGGRenderer)
38-
let agg_renderer = AGGRenderer()
39-
try lineGraph.drawGraphAndOutput(fileName: aggOutputDirectory+fileName,
40-
renderer: agg_renderer)
41-
verifyImage(name: fileName, renderer: .agg)
42-
#endif
43-
/*
44-
#if canImport(QuartzRenderer)
45-
let quartz_renderer = QuartzRenderer()
46-
try lineGraph.drawGraphAndOutput(fileName: coreGraphicsOutputDirectory+fileName,
47-
renderer: quartz_renderer)
48-
verifyImage(name: fileName, renderer: .coreGraphics)
49-
#endif
50-
*/
33+
try renderAndVerify(lineGraph, fileName: fileName)
5134
}
5235
}

Tests/SwiftPlotTests/Annotation/annotation-arrow-double-headed.swift

+1-18
Original file line numberDiff line numberDiff line change
@@ -26,23 +26,6 @@ extension AnnotationTests {
2626
end: Point(585.0, 585.0),
2727
isDoubleHeaded: true))
2828

29-
let svg_renderer = SVGRenderer()
30-
try lineGraph.drawGraphAndOutput(fileName: svgOutputDirectory+fileName,
31-
renderer: svg_renderer)
32-
verifyImage(name: fileName, renderer: .svg)
33-
#if canImport(AGGRenderer)
34-
let agg_renderer = AGGRenderer()
35-
try lineGraph.drawGraphAndOutput(fileName: aggOutputDirectory+fileName,
36-
renderer: agg_renderer)
37-
verifyImage(name: fileName, renderer: .agg)
38-
#endif
39-
/*
40-
#if canImport(QuartzRenderer)
41-
let quartz_renderer = QuartzRenderer()
42-
try lineGraph.drawGraphAndOutput(fileName: coreGraphicsOutputDirectory+fileName,
43-
renderer: quartz_renderer)
44-
verifyImage(name: fileName, renderer: .coreGraphics)
45-
#endif
46-
*/
29+
try renderAndVerify(lineGraph, fileName: fileName)
4730
}
4831
}

Tests/SwiftPlotTests/Annotation/annotation-arrow-wedge.swift

+1-18
Original file line numberDiff line numberDiff line change
@@ -29,23 +29,6 @@ extension AnnotationTests {
2929
startAnnotation: Text(text: "relative maxima",
3030
direction: .west)))
3131

32-
let svg_renderer = SVGRenderer()
33-
try lineGraph.drawGraphAndOutput(fileName: svgOutputDirectory+fileName,
34-
renderer: svg_renderer)
35-
verifyImage(name: fileName, renderer: .svg)
36-
#if canImport(AGGRenderer)
37-
let agg_renderer = AGGRenderer()
38-
try lineGraph.drawGraphAndOutput(fileName: aggOutputDirectory+fileName,
39-
renderer: agg_renderer)
40-
verifyImage(name: fileName, renderer: .agg)
41-
#endif
42-
/*
43-
#if canImport(QuartzRenderer)
44-
let quartz_renderer = QuartzRenderer()
45-
try lineGraph.drawGraphAndOutput(fileName: coreGraphicsOutputDirectory+fileName,
46-
renderer: quartz_renderer)
47-
verifyImage(name: fileName, renderer: .coreGraphics)
48-
#endif
49-
*/
32+
try renderAndVerify(lineGraph, fileName: fileName)
5033
}
5134
}

Tests/SwiftPlotTests/Annotation/annotation-arrow.swift

+1-18
Original file line numberDiff line numberDiff line change
@@ -27,23 +27,6 @@ extension AnnotationTests {
2727
startAnnotation: Text(text: "relative maxima",
2828
direction: .west)))
2929

30-
let svg_renderer = SVGRenderer()
31-
try lineGraph.drawGraphAndOutput(fileName: svgOutputDirectory+fileName,
32-
renderer: svg_renderer)
33-
verifyImage(name: fileName, renderer: .svg)
34-
#if canImport(AGGRenderer)
35-
let agg_renderer = AGGRenderer()
36-
try lineGraph.drawGraphAndOutput(fileName: aggOutputDirectory+fileName,
37-
renderer: agg_renderer)
38-
verifyImage(name: fileName, renderer: .agg)
39-
#endif
40-
/*
41-
#if canImport(QuartzRenderer)
42-
let quartz_renderer = QuartzRenderer()
43-
try lineGraph.drawGraphAndOutput(fileName: coreGraphicsOutputDirectory+fileName,
44-
renderer: quartz_renderer)
45-
verifyImage(name: fileName, renderer: .coreGraphics)
46-
#endif
47-
*/
30+
try renderAndVerify(lineGraph, fileName: fileName)
4831
}
4932
}

Tests/SwiftPlotTests/Annotation/annotation-text-bounding-box.swift

+1-16
Original file line numberDiff line numberDiff line change
@@ -31,21 +31,6 @@ extension AnnotationTests {
3131
boundingBox: Box(color: .pink),
3232
borderWidth: 5.0))
3333

34-
let svg_renderer = SVGRenderer()
35-
try lineGraph.drawGraphAndOutput(fileName: svgOutputDirectory+fileName,
36-
renderer: svg_renderer)
37-
verifyImage(name: fileName, renderer: .svg)
38-
#if canImport(AGGRenderer)
39-
let agg_renderer = AGGRenderer()
40-
try lineGraph.drawGraphAndOutput(fileName: aggOutputDirectory+fileName,
41-
renderer: agg_renderer)
42-
verifyImage(name: fileName, renderer: .agg)
43-
#endif
44-
#if canImport(QuartzRenderer)
45-
let quartz_renderer = QuartzRenderer()
46-
try lineGraph.drawGraphAndOutput(fileName: coreGraphicsOutputDirectory+fileName,
47-
renderer: quartz_renderer)
48-
verifyImage(name: fileName, renderer: .coreGraphics)
49-
#endif
34+
try renderAndVerify(lineGraph, fileName: fileName)
5035
}
5136
}

Tests/SwiftPlotTests/Annotation/annotation-text.swift

+1-16
Original file line numberDiff line numberDiff line change
@@ -29,21 +29,6 @@ extension AnnotationTests {
2929
size: 50.0,
3030
location: Point(300, 300)))
3131

32-
let svg_renderer = SVGRenderer()
33-
try lineGraph.drawGraphAndOutput(fileName: svgOutputDirectory+fileName,
34-
renderer: svg_renderer)
35-
verifyImage(name: fileName, renderer: .svg)
36-
#if canImport(AGGRenderer)
37-
let agg_renderer = AGGRenderer()
38-
try lineGraph.drawGraphAndOutput(fileName: aggOutputDirectory+fileName,
39-
renderer: agg_renderer)
40-
verifyImage(name: fileName, renderer: .agg)
41-
#endif
42-
#if canImport(QuartzRenderer)
43-
let quartz_renderer = QuartzRenderer()
44-
try lineGraph.drawGraphAndOutput(fileName: coreGraphicsOutputDirectory+fileName,
45-
renderer: quartz_renderer)
46-
verifyImage(name: fileName, renderer: .coreGraphics)
47-
#endif
32+
try renderAndVerify(lineGraph, fileName: fileName)
4833
}
4934
}

Tests/SwiftPlotTests/BarChart/barchart-hatched-backwardslash.swift

+1-16
Original file line numberDiff line numberDiff line change
@@ -22,21 +22,6 @@ extension BarchartTests {
2222
barGraph.plotTitle = PlotTitle("HATCHED BAR CHART")
2323
barGraph.plotLabel = PlotLabel(xLabel: "X-AXIS", yLabel: "Y-AXIS")
2424

25-
let svg_renderer = SVGRenderer()
26-
try barGraph.drawGraphAndOutput(fileName: svgOutputDirectory+fileName,
27-
renderer: svg_renderer)
28-
verifyImage(name: fileName, renderer: .svg)
29-
#if canImport(AGGRenderer)
30-
let agg_renderer = AGGRenderer()
31-
try barGraph.drawGraphAndOutput(fileName: aggOutputDirectory+fileName,
32-
renderer: agg_renderer)
33-
verifyImage(name: fileName, renderer: .agg)
34-
#endif
35-
#if canImport(QuartzRenderer)
36-
let quartz_renderer = QuartzRenderer()
37-
try barGraph.drawGraphAndOutput(fileName: coreGraphicsOutputDirectory+fileName,
38-
renderer: quartz_renderer)
39-
verifyImage(name: fileName, renderer: .coreGraphics)
40-
#endif
25+
try renderAndVerify(barGraph, fileName: fileName)
4126
}
4227
}

Tests/SwiftPlotTests/BarChart/barchart-hatched-cross.swift

+1-16
Original file line numberDiff line numberDiff line change
@@ -24,21 +24,6 @@ extension BarchartTests {
2424
barGraph.plotTitle = PlotTitle("HATCHED BAR CHART")
2525
barGraph.plotLabel = PlotLabel(xLabel: "X-AXIS", yLabel: "Y-AXIS")
2626

27-
let svg_renderer = SVGRenderer()
28-
try barGraph.drawGraphAndOutput(fileName: svgOutputDirectory+fileName,
29-
renderer: svg_renderer)
30-
verifyImage(name: fileName, renderer: .svg)
31-
#if canImport(AGGRenderer)
32-
let agg_renderer = AGGRenderer()
33-
try barGraph.drawGraphAndOutput(fileName: aggOutputDirectory+fileName,
34-
renderer: agg_renderer)
35-
verifyImage(name: fileName, renderer: .agg)
36-
#endif
37-
#if canImport(QuartzRenderer)
38-
let quartz_renderer = QuartzRenderer()
39-
try barGraph.drawGraphAndOutput(fileName: coreGraphicsOutputDirectory+fileName,
40-
renderer: quartz_renderer)
41-
verifyImage(name: fileName, renderer: .coreGraphics)
42-
#endif
27+
try renderAndVerify(barGraph, fileName: fileName)
4328
}
4429
}

Tests/SwiftPlotTests/BarChart/barchart-hatched-filledcircle.swift

+1-16
Original file line numberDiff line numberDiff line change
@@ -22,21 +22,6 @@ extension BarchartTests {
2222
barGraph.plotTitle = PlotTitle("HATCHED BAR CHART")
2323
barGraph.plotLabel = PlotLabel(xLabel: "X-AXIS", yLabel: "Y-AXIS")
2424

25-
let svg_renderer = SVGRenderer()
26-
try barGraph.drawGraphAndOutput(fileName: svgOutputDirectory+fileName,
27-
renderer: svg_renderer)
28-
verifyImage(name: fileName, renderer: .svg)
29-
#if canImport(AGGRenderer)
30-
let agg_renderer = AGGRenderer()
31-
try barGraph.drawGraphAndOutput(fileName: aggOutputDirectory+fileName,
32-
renderer: agg_renderer)
33-
verifyImage(name: fileName, renderer: .agg)
34-
#endif
35-
#if canImport(QuartzRenderer)
36-
let quartz_renderer = QuartzRenderer()
37-
try barGraph.drawGraphAndOutput(fileName: coreGraphicsOutputDirectory+fileName,
38-
renderer: quartz_renderer)
39-
verifyImage(name: fileName, renderer: .coreGraphics)
40-
#endif
25+
try renderAndVerify(barGraph, fileName: fileName)
4126
}
4227
}

Tests/SwiftPlotTests/BarChart/barchart-hatched-forwardsslash.swift

+1-16
Original file line numberDiff line numberDiff line change
@@ -22,21 +22,6 @@ extension BarchartTests {
2222
barGraph.plotTitle = PlotTitle("HATCHED BAR CHART")
2323
barGraph.plotLabel = PlotLabel(xLabel: "X-AXIS", yLabel: "Y-AXIS")
2424

25-
let svg_renderer = SVGRenderer()
26-
try barGraph.drawGraphAndOutput(fileName: svgOutputDirectory+fileName,
27-
renderer: svg_renderer)
28-
verifyImage(name: fileName, renderer: .svg)
29-
#if canImport(AGGRenderer)
30-
let agg_renderer = AGGRenderer()
31-
try barGraph.drawGraphAndOutput(fileName: aggOutputDirectory+fileName,
32-
renderer: agg_renderer)
33-
verifyImage(name: fileName, renderer: .agg)
34-
#endif
35-
#if canImport(QuartzRenderer)
36-
let quartz_renderer = QuartzRenderer()
37-
try barGraph.drawGraphAndOutput(fileName: coreGraphicsOutputDirectory+fileName,
38-
renderer: quartz_renderer)
39-
verifyImage(name: fileName, renderer: .coreGraphics)
40-
#endif
25+
try renderAndVerify(barGraph, fileName: fileName)
4126
}
4227
}

Tests/SwiftPlotTests/BarChart/barchart-hatched-grid.swift

+1-16
Original file line numberDiff line numberDiff line change
@@ -22,21 +22,6 @@ extension BarchartTests {
2222
barGraph.plotTitle = PlotTitle("HATCHED BAR CHART")
2323
barGraph.plotLabel = PlotLabel(xLabel: "X-AXIS", yLabel: "Y-AXIS")
2424

25-
let svg_renderer = SVGRenderer()
26-
try barGraph.drawGraphAndOutput(fileName: svgOutputDirectory+fileName,
27-
renderer: svg_renderer)
28-
verifyImage(name: fileName, renderer: .svg)
29-
#if canImport(AGGRenderer)
30-
let agg_renderer = AGGRenderer()
31-
try barGraph.drawGraphAndOutput(fileName: aggOutputDirectory+fileName,
32-
renderer: agg_renderer)
33-
verifyImage(name: fileName, renderer: .agg)
34-
#endif
35-
#if canImport(QuartzRenderer)
36-
let quartz_renderer = QuartzRenderer()
37-
try barGraph.drawGraphAndOutput(fileName: coreGraphicsOutputDirectory+fileName,
38-
renderer: quartz_renderer)
39-
verifyImage(name: fileName, renderer: .coreGraphics)
40-
#endif
25+
try renderAndVerify(barGraph, fileName: fileName)
4126
}
4227
}

Tests/SwiftPlotTests/BarChart/barchart-hatched-hollowcircle.swift

+1-16
Original file line numberDiff line numberDiff line change
@@ -22,21 +22,6 @@ extension BarchartTests {
2222
barGraph.plotTitle = PlotTitle("HATCHED BAR CHART")
2323
barGraph.plotLabel = PlotLabel(xLabel: "X-AXIS", yLabel: "Y-AXIS")
2424

25-
let svg_renderer = SVGRenderer()
26-
try barGraph.drawGraphAndOutput(fileName: svgOutputDirectory+fileName,
27-
renderer: svg_renderer)
28-
verifyImage(name: fileName, renderer: .svg)
29-
#if canImport(AGGRenderer)
30-
let agg_renderer = AGGRenderer()
31-
try barGraph.drawGraphAndOutput(fileName: aggOutputDirectory+fileName,
32-
renderer: agg_renderer)
33-
verifyImage(name: fileName, renderer: .agg)
34-
#endif
35-
#if canImport(QuartzRenderer)
36-
let quartz_renderer = QuartzRenderer()
37-
try barGraph.drawGraphAndOutput(fileName: coreGraphicsOutputDirectory+fileName,
38-
renderer: quartz_renderer)
39-
verifyImage(name: fileName, renderer: .coreGraphics)
40-
#endif
25+
try renderAndVerify(barGraph, fileName: fileName)
4126
}
4227
}

Tests/SwiftPlotTests/BarChart/barchart-hatched-horizontal.swift

+1-16
Original file line numberDiff line numberDiff line change
@@ -22,21 +22,6 @@ extension BarchartTests {
2222
barGraph.plotTitle = PlotTitle("HATCHED BAR CHART")
2323
barGraph.plotLabel = PlotLabel(xLabel: "X-AXIS", yLabel: "Y-AXIS")
2424

25-
let svg_renderer = SVGRenderer()
26-
try barGraph.drawGraphAndOutput(fileName: svgOutputDirectory+fileName,
27-
renderer: svg_renderer)
28-
verifyImage(name: fileName, renderer: .svg)
29-
#if canImport(AGGRenderer)
30-
let agg_renderer = AGGRenderer()
31-
try barGraph.drawGraphAndOutput(fileName: aggOutputDirectory+fileName,
32-
renderer: agg_renderer)
33-
verifyImage(name: fileName, renderer: .agg)
34-
#endif
35-
#if canImport(QuartzRenderer)
36-
let quartz_renderer = QuartzRenderer()
37-
try barGraph.drawGraphAndOutput(fileName: coreGraphicsOutputDirectory+fileName,
38-
renderer: quartz_renderer)
39-
verifyImage(name: fileName, renderer: .coreGraphics)
40-
#endif
25+
try renderAndVerify(barGraph, fileName: fileName)
4126
}
4227
}

Tests/SwiftPlotTests/BarChart/barchart-hatched-vertical.swift

+1-16
Original file line numberDiff line numberDiff line change
@@ -22,21 +22,6 @@ extension BarchartTests {
2222
barGraph.plotTitle = PlotTitle("HATCHED BAR CHART")
2323
barGraph.plotLabel = PlotLabel(xLabel: "X-AXIS", yLabel: "Y-AXIS")
2424

25-
let svg_renderer = SVGRenderer()
26-
try barGraph.drawGraphAndOutput(fileName: svgOutputDirectory+fileName,
27-
renderer: svg_renderer)
28-
verifyImage(name: fileName, renderer: .svg)
29-
#if canImport(AGGRenderer)
30-
let agg_renderer = AGGRenderer()
31-
try barGraph.drawGraphAndOutput(fileName: aggOutputDirectory+fileName,
32-
renderer: agg_renderer)
33-
verifyImage(name: fileName, renderer: .agg)
34-
#endif
35-
#if canImport(QuartzRenderer)
36-
let quartz_renderer = QuartzRenderer()
37-
try barGraph.drawGraphAndOutput(fileName: coreGraphicsOutputDirectory+fileName,
38-
renderer: quartz_renderer)
39-
verifyImage(name: fileName, renderer: .coreGraphics)
40-
#endif
25+
try renderAndVerify(barGraph, fileName: fileName)
4126
}
4227
}

Tests/SwiftPlotTests/BarChart/barchart-orientation-horizontal.swift

+1-16
Original file line numberDiff line numberDiff line change
@@ -22,21 +22,6 @@ extension BarchartTests {
2222
barGraph.plotTitle = PlotTitle("BAR CHART")
2323
barGraph.plotLabel = PlotLabel(xLabel: "X-AXIS", yLabel: "Y-AXIS")
2424

25-
let svg_renderer = SVGRenderer()
26-
try barGraph.drawGraphAndOutput(fileName: svgOutputDirectory+fileName,
27-
renderer: svg_renderer)
28-
verifyImage(name: fileName, renderer: .svg)
29-
#if canImport(AGGRenderer)
30-
let agg_renderer = AGGRenderer()
31-
try barGraph.drawGraphAndOutput(fileName: aggOutputDirectory+fileName,
32-
renderer: agg_renderer)
33-
verifyImage(name: fileName, renderer: .agg)
34-
#endif
35-
#if canImport(QuartzRenderer)
36-
let quartz_renderer = QuartzRenderer()
37-
try barGraph.drawGraphAndOutput(fileName: coreGraphicsOutputDirectory+fileName,
38-
renderer: quartz_renderer)
39-
verifyImage(name: fileName, renderer: .coreGraphics)
40-
#endif
25+
try renderAndVerify(barGraph, fileName: fileName)
4126
}
4227
}

Tests/SwiftPlotTests/BarChart/barchart-stacked-horizontal.swift

+1-16
Original file line numberDiff line numberDiff line change
@@ -24,21 +24,6 @@ extension BarchartTests {
2424
barGraph.plotTitle = PlotTitle("BAR CHART")
2525
barGraph.plotLabel = PlotLabel(xLabel: "X-AXIS", yLabel: "Y-AXIS")
2626

27-
let svg_renderer = SVGRenderer()
28-
try barGraph.drawGraphAndOutput(fileName: svgOutputDirectory+fileName,
29-
renderer: svg_renderer)
30-
verifyImage(name: fileName, renderer: .svg)
31-
#if canImport(AGGRenderer)
32-
let agg_renderer = AGGRenderer()
33-
try barGraph.drawGraphAndOutput(fileName: aggOutputDirectory+fileName,
34-
renderer: agg_renderer)
35-
verifyImage(name: fileName, renderer: .agg)
36-
#endif
37-
#if canImport(QuartzRenderer)
38-
let quartz_renderer = QuartzRenderer()
39-
try barGraph.drawGraphAndOutput(fileName: coreGraphicsOutputDirectory+fileName,
40-
renderer: quartz_renderer)
41-
verifyImage(name: fileName, renderer: .coreGraphics)
42-
#endif
27+
try renderAndVerify(barGraph, fileName: fileName)
4328
}
4429
}

Tests/SwiftPlotTests/BarChart/barchart-stacked-vertical.swift

+1-16
Original file line numberDiff line numberDiff line change
@@ -24,21 +24,6 @@ extension BarchartTests {
2424
barGraph.plotTitle = PlotTitle("BAR CHART")
2525
barGraph.plotLabel = PlotLabel(xLabel: "X-AXIS", yLabel: "Y-AXIS")
2626

27-
let svg_renderer = SVGRenderer()
28-
try barGraph.drawGraphAndOutput(fileName: svgOutputDirectory+fileName,
29-
renderer: svg_renderer)
30-
verifyImage(name: fileName, renderer: .svg)
31-
#if canImport(AGGRenderer)
32-
let agg_renderer = AGGRenderer()
33-
try barGraph.drawGraphAndOutput(fileName: aggOutputDirectory+fileName,
34-
renderer: agg_renderer)
35-
verifyImage(name: fileName, renderer: .agg)
36-
#endif
37-
#if canImport(QuartzRenderer)
38-
let quartz_renderer = QuartzRenderer()
39-
try barGraph.drawGraphAndOutput(fileName: coreGraphicsOutputDirectory+fileName,
40-
renderer: quartz_renderer)
41-
verifyImage(name: fileName, renderer: .coreGraphics)
42-
#endif
27+
try renderAndVerify(barGraph, fileName: fileName)
4328
}
4429
}

0 commit comments

Comments
 (0)