Skip to content

Commit e888c23

Browse files
committed
docs: update CONTRIBUTING.md
feedback from #406
1 parent 0ce9f0f commit e888c23

File tree

2 files changed

+94
-49
lines changed

2 files changed

+94
-49
lines changed

CONTRIBUTING.md

+93-48
Original file line numberDiff line numberDiff line change
@@ -1,79 +1,124 @@
1-
# Contributing to this repository <!-- omit in toc -->
1+
# 🚀 Contribution Workflow
22

3-
## Getting started <!-- omit in toc -->
3+
Thank you for your interest in contributing to this project! 🎉 Follow the steps below to set up your development environment and submit contributions.
44

5-
Before you begin:
5+
## 🏁 Getting Started
66

7-
- This site is powered by Node.js. Check to see if you're on the [version of node we support](contributing/development.md).
8-
- Have you read the [code of conduct](CODE_OF_CONDUCT.md)?
9-
- Check out the [existing issues](https://github.com/MelihAltintas/vue3-openlayers/issues).
7+
1. **🔗 Fork the Repository**: Click the "Fork" button on the GitHub repository page to create your own copy. You can fork the repository using:
108

11-
## Don't see your issue? Open one
9+
- [GitHub Desktop](https://docs.github.com/en/desktop/installing-and-configuring-github-desktop/getting-started-with-github-desktop)
10+
- [Command Line](https://docs.github.com/en/github/getting-started-with-github/fork-a-repo#fork-an-example-repository)
11+
- [GitHub Codespaces](https://github.com/features/codespaces)
1212

13-
If you spot something new, open an issue using a [template](https://github.com/MelihAltintas/vue3-openlayers/issues/new/choose).
14-
We'll use the issue to have a conversation about the problem you want to fix.
13+
1. **📂 Clone Your Fork**: Clone your forked repository to your local machine:
14+
```sh
15+
git clone https://github.com/YOUR_USERNAME/vue3-openlayers.git
16+
cd vue3-openlayers
17+
```
18+
1. **📦 Install Dependencies**: Run the following command to install required dependencies:
19+
```sh
20+
npm install
21+
```
22+
1. **💻 Start Local Development**: Use the following command to start the development environment:
23+
```sh
24+
npm run serve
25+
```
26+
1. **📜 Read Guidelines**: Have you read the [code of conduct](CODE_OF_CONDUCT.md)?
1527

16-
## Ready to make a change? Fork the repo
28+
## 🔄 Keeping Your Fork Updated
1729

18-
Fork using GitHub Desktop:
30+
To sync your fork with the latest changes from the main repository:
1931

20-
- [Getting started with GitHub Desktop](https://docs.github.com/en/desktop/installing-and-configuring-github-desktop/getting-started-with-github-desktop) will guide you through setting up Desktop.
21-
- Once Desktop is set up, you can use it to [fork the repo](https://docs.github.com/en/desktop/contributing-and-collaborating-using-github-desktop/cloning-and-forking-repositories-from-github-desktop)!
32+
1. **🌍 Add the Main Repository as a Remote** (if not already added):
2233

23-
Fork using the command line:
34+
```sh
35+
git remote add upstream https://github.com/MelihAltintas/vue3-openlayers.git
36+
```
2437

25-
- [Fork the repo](https://docs.github.com/en/github/getting-started-with-github/fork-a-repo#fork-an-example-repository) so that you can make your changes without affecting the original project until you're ready to merge them.
38+
2. **📥 Fetch the Latest Changes**:
2639

27-
Fork with [GitHub Codespaces](https://github.com/features/codespaces):
40+
```sh
41+
git fetch upstream
42+
```
2843

29-
- [Fork, edit, and preview](https://docs.github.com/en/free-pro-team@latest/github/developing-online-with-codespaces/creating-a-codespace) using [GitHub Codespaces](https://github.com/features/codespaces) without having to install and run the project locally.
44+
3. **🔀 Merge the Changes into Your Local Branch**:
3045

31-
## Make your update
46+
```sh
47+
git checkout main
48+
git merge upstream/main
49+
```
3250

33-
Make your changes to the file(s) you'd like to update.
34-
Please be sure to update the documentation as well, when adding new features or changing the API.
51+
4. **📤 Push the Updated Branch to Your Fork**:
3552

36-
## Open a pull request
53+
```sh
54+
git push origin main
55+
```
3756

38-
When you're done making changes and you'd like to propose them for review, open your PR (pull request).
57+
## 🛠️ Making Changes
3958

40-
## Submit your PR & get it reviewed
59+
Ensure your changes include documentation updates where applicable. Follow the steps above to create a new branch and make your updates.
4160

42-
- Once you submit your PR, others from the community will review it with you.
43-
- After that, we may have questions, check back on your PR to keep up with the conversation.
44-
- Did you have an issue, like a merge conflict? Check out our [git tutorial](https://lab.github.com/githubtraining/managing-merge-conflicts) on how to resolve merge conflicts and other issues.
61+
Before submitting, review your pull request:
4562

46-
## Self review
63+
- Confirm user experience matches the design.
64+
- Ensure content and code accuracy.
65+
- Check for grammar and style guide adherence.
66+
- Troubleshoot any failing checks.
4767

48-
You should always review your own PR first.
68+
1. **🌿 Create a Branch**: Before making changes, create a new branch:
4969

50-
For content changes, make sure that you:
70+
```sh
71+
git checkout -b feature/your-feature-name
72+
```
5173

52-
- [ ] Confirm that the changes meet the user experience and goals outlined in the content design plan (if there is one).
53-
- [ ] Compare your pull request's source changes to staging to confirm that the output matches the source and that everything is rendering as expected.
54-
- [ ] This helps spot issues like typos, content that doesn't follow the style guide, or content that isn't rendering due to versioning problems.
55-
- [ ] Remember that lists and tables can be tricky.
56-
- [ ] Review the content for technical accuracy.
57-
- [ ] Copy-edit the changes for grammar, spelling, and adherence.
58-
- [ ] If there are any failing checks in your PR, troubleshoot them until they're all passing.
74+
2. **✏️ Make Your Changes**: Edit files and implement your changes.
5975

60-
## Reviewing
76+
3. **🎨 Verify Style**: Follow Code Guidelines by checking for lint errors and format code correctly:
6177

62-
We review every single PR. The purpose of reviews is to create the best content we can for people who use this library.
78+
```sh
79+
npm run lint # check for linting issues
80+
npm run lint-fix # check for linting issues and auto-fix if possible
81+
npm run format # format the code using prettier
82+
```
6383

64-
:yellow_heart: Reviews are always respectful, acknowledging that everyone did the best possible job with the knowledge they had at the time.
65-
:yellow_heart: Reviews discuss content, not the person who created it.
66-
:yellow_heart: Reviews are constructive and start conversation around feedback.
84+
4. **✅ Commit Your Changes**: Follow conventional commit messages:
6785

68-
## Suggested changes
86+
```sh
87+
git add .
88+
git commit -m "feat: add new feature description"
89+
```
6990

70-
We may ask for changes to be made before a PR can be merged, either using [suggested changes](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/incorporating-feedback-in-your-pull-request) or pull request comments.
71-
You can apply suggested changes directly through the UI. You can make any other changes in your fork, then commit them to your branch.
91+
5. **🚀 Push Your Branch**: Push your changes to your fork:
7292

73-
As you update your PR and apply changes, mark each conversation as [resolved](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request#resolving-conversations).
93+
```sh
94+
git push origin feature/your-feature-name
95+
```
7496

75-
## Your PR is merged!
97+
## 🔃 Submitting a Pull Request
7698

77-
Congratulations! The whole community thanks you. :sparkles:
99+
1. Go to the original repository on GitHub.
100+
2. Click on "New Pull Request".
101+
3. Select your branch and provide a clear description of your changes.
102+
4. Submit the pull request. 🎯
78103

79-
Once your PR is merged, you will be proudly listed as a contributor in the [contributor chart](https://github.com/MelihAltintas/vue3-openlayers/graphs/contributors).
104+
## 🔍 Code Review & Merging
105+
106+
We review every PR to ensure high content quality.
107+
108+
- ✅ Your pull request will be reviewed by maintainers.
109+
- ✏️ You may be asked to make modifications.
110+
- Reviews are respectful and constructive.
111+
- Follow-up on review comments and mark as resolved when done.
112+
- 🎉 Once approved, your changes will be merged into the main branch.
113+
114+
## 📌 Additional Notes
115+
116+
- 🔍 Ensure that all changes adhere to the project's coding guidelines.
117+
- 🧪 Run tests before submitting changes (if applicable).
118+
- 🔄 Keep your branch up to date with the latest changes from `main`.
119+
120+
### ⛙ Merging
121+
122+
Upon merging, you'll be recognized in the [contributor chart](https://github.com/MelihAltintas/vue3-openlayers/graphs/contributors).
123+
124+
Thank you for contributing! 🙌

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
},
5454
"scripts": {
5555
"build": "vite build",
56-
"serve": "vite preview",
56+
"serve": "npm run docs:dev",
5757
"docs:dev": "vitepress dev docs",
5858
"docs:dev:debug": "VITE_DEBUG=true npm run docs:dev",
5959
"docs:build": "vitepress build docs",

0 commit comments

Comments
 (0)