Skip to content
This repository was archived by the owner on Sep 3, 2024. It is now read-only.

Commit b20ca6b

Browse files
Merge pull request #63 from thefringeninja/replacement-killer
ಠ_ಠ
2 parents 24aaec6 + dddcfb6 commit b20ca6b

File tree

4 files changed

+20
-11
lines changed

4 files changed

+20
-11
lines changed

Diff for: package.json

-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@
6363
"react-remarkable": "1.1.3",
6464
"react-schema-form": "0.6.2",
6565
"rxjs": "5.4.3",
66-
"uri-js": "4.2.2",
6766
"uri-template": "1.0.1",
6867
"uuid": "3.3.2"
6968
},

Diff for: src/stream-store/Viewer/HalViewer/components/JsonViewer.tsx

+17-7
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { connect, createState } from 'reactive';
77
import { Observable } from 'rxjs';
88
import rels from 'stream-store/rels';
99
import themes from 'themes';
10-
import { HalResource, NavigatableProps } from 'types';
10+
import { HalResource, HttpResponse, NavigatableProps } from 'types';
1111
import uriTemplate from 'uri-template';
1212
import { hal, http, reactJsonTheme } from 'utils';
1313

@@ -81,7 +81,7 @@ class JsonViewer extends PureComponent<
8181
);
8282

8383
const responses = await Promise.all(
84-
[...new Set([pattern, String(pattern).replace('-', '')])].map(p =>
84+
[...new Set([pattern, String(pattern).replace(/-/g, '')])].map(p =>
8585
http.get({
8686
headers: { authorization },
8787
link: {
@@ -91,16 +91,26 @@ class JsonViewer extends PureComponent<
9191
),
9292
);
9393

94+
const streams = this._getStreams(responses);
95+
9496
this.setState({
9597
loading: false,
96-
streams: Object.values(
97-
responses.flatMap(({ body }) =>
98-
getStreamLinks(hal.normalizeResource(body as HalResource)),
99-
),
100-
),
98+
streams,
10199
});
102100
};
103101

102+
_getStreams = (responses: HttpResponse[]) =>
103+
Object.values(
104+
responses
105+
.flatMap(({ body }) =>
106+
getStreamLinks(hal.normalizeResource(body as HalResource)),
107+
)
108+
.map(({ _links, ...resource }) => ({
109+
...resource,
110+
_links: hal.resolveLinks('../../', _links),
111+
})),
112+
);
113+
104114
_handlePotentialStreamIdClose = () =>
105115
this.setState({
106116
open: false,

Diff for: src/utils/hal.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
import { HalLink, HalLinks, HalResource } from 'types';
2-
import { resolve } from 'uri-js';
2+
import URL from 'url';
33

44
const resolveLinks = (url: string, links: HalLinks): HalLinks =>
55
Object.keys(links).reduce(
66
(akk, rel) => ({
77
...akk,
88
[rel]: links[rel].map(({ href, ...link }) => ({
99
...link,
10-
href: resolve(url, href || './', { tolerant: true }),
10+
href: URL.resolve(url, href || './'),
1111
rel,
1212
})),
1313
}),

Diff for: yarn.lock

+1-1
Original file line numberDiff line numberDiff line change
@@ -7740,7 +7740,7 @@ upper-case@^1.1.1:
77407740
version "1.1.3"
77417741
resolved "https://registry.yarnpkg.com/upper-case/-/upper-case-1.1.3.tgz#f6b4501c2ec4cdd26ba78be7222961de77621598"
77427742

7743-
uri-js@4.2.2, uri-js@^4.2.2:
7743+
uri-js@^4.2.2:
77447744
version "4.2.2"
77457745
resolved "https://registry.yarnpkg.com/uri-js/-/uri-js-4.2.2.tgz#94c540e1ff772956e2299507c010aea6c8838eb0"
77467746
dependencies:

0 commit comments

Comments
 (0)