Skip to content

Commit 96d9c53

Browse files
committed
Fix method addCredential()
1 parent de63183 commit 96d9c53

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

java/src/org/openqa/selenium/remote/RemoteWebDriver.java

+4-6
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import java.util.LinkedHashSet;
3737
import java.util.List;
3838
import java.util.Map;
39+
import java.util.HashMap;
3940
import java.util.Set;
4041
import java.util.concurrent.TimeUnit;
4142
import java.util.function.BiFunction;
@@ -1248,12 +1249,9 @@ public String getId() {
12481249

12491250
@Override
12501251
public void addCredential(Credential credential) {
1251-
execute(
1252-
DriverCommand.ADD_CREDENTIAL,
1253-
Stream.concat(
1254-
credential.toMap().entrySet().stream(),
1255-
Stream.of(Map.entry("authenticatorId", id)))
1256-
.collect(Collectors.toUnmodifiableMap(Map.Entry::getKey, Map.Entry::getValue)));
1252+
Map<String, Object> map = new HashMap<>(credential.toMap());
1253+
map.put("authenticatorId", id);
1254+
execute(DriverCommand.ADD_CREDENTIAL, map);
12571255
}
12581256

12591257
@Override

java/src/org/openqa/selenium/virtualauthenticator/Credential.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public static Credential fromMap(Map<String, Object> map) {
6666
Object credentialId = Require.nonNull("credentialId", map.get("credentialId"));
6767
Object isResidentCredential =
6868
Require.nonNull("isResidentCredential", map.get("isResidentCredential"));
69-
Object rpId = map.get("rpId");
69+
Object rpId = Require.nonNull("rpId", map.get("rpId"));
7070
Object privateKey = Require.nonNull("privateKey", map.get("privateKey"));
7171
Object userHandle = map.get("userHandle");
7272
Object signCount = Require.nonNull("signCount", map.get("signCount"));

0 commit comments

Comments
 (0)