Merge pull request #711 from adafruit/add-Werror=return-type

add -Werror=return-type for all warning options

Author: hathach

Diff for: libraries/SPI/SPI.cpp

@@ -208,7 +208,7 @@ void SPIClass::transfer(const void *tx_buf, void *rx_buf, size_t count)
   while (count)
   {
     // each transfer can only up to 64KB (16-bit) bytes
-    const size_t xfer_len = min(count, UINT16_MAX);
+    const size_t xfer_len = min(count, (size_t) UINT16_MAX);
 
     nrfx_spim_xfer_desc_t xfer_desc =
     {

Diff for: platform.txt

@@ -22,11 +22,11 @@ version=1.2.0
 # Compile variables
 # -----------------
 
-compiler.warning_flags=-w
-compiler.warning_flags.none=-w
-compiler.warning_flags.default=
-compiler.warning_flags.more=-Wall
-compiler.warning_flags.all=-Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-pointer-arith
+compiler.warning_flags=-Werror=return-type
+compiler.warning_flags.none=-Werror=return-type
+compiler.warning_flags.default=-Werror=return-type
+compiler.warning_flags.more=-Wall -Werror=return-type
+compiler.warning_flags.all=-Wall -Wextra -Werror=return-type -Wno-unused-parameter -Wno-missing-field-initializers -Wno-pointer-arith
 
 # Allow changing optimization settings via platform.local.txt / boards.local.txt
 compiler.optimization_flag=-Ofast