Skip to content

Commit eeba3a8

Browse files
committed
refactor: add missing peer depedency on @angular/core and tslib
This is required to support strict mode in pnpm. Closes #30068
1 parent ee2b4cb commit eeba3a8

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

Diff for: packages/angular/build/package.json

+5
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@
5757
"rxjs": "7.8.2"
5858
},
5959
"peerDependencies": {
60+
"@angular/core": "0.0.0-ANGULAR-FW-PEER-DEP",
6061
"@angular/compiler": "0.0.0-ANGULAR-FW-PEER-DEP",
6162
"@angular/compiler-cli": "0.0.0-ANGULAR-FW-PEER-DEP",
6263
"@angular/localize": "0.0.0-ANGULAR-FW-PEER-DEP",
@@ -69,9 +70,13 @@
6970
"ng-packagr": "0.0.0-NG-PACKAGR-PEER-DEP",
7071
"postcss": "^8.4.0",
7172
"tailwindcss": "^2.0.0 || ^3.0.0 || ^4.0.0",
73+
"tslib": "^2.3.0",
7274
"typescript": ">=5.8 <5.9"
7375
},
7476
"peerDependenciesMeta": {
77+
"@angular/core": {
78+
"optional": true
79+
},
7580
"@angular/localize": {
7681
"optional": true
7782
},

Diff for: packages/angular_devkit/build_angular/package.json

+4
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@
7373
"undici": "7.7.0"
7474
},
7575
"peerDependencies": {
76+
"@angular/core": "0.0.0-ANGULAR-FW-PEER-DEP",
7677
"@angular/compiler-cli": "0.0.0-ANGULAR-FW-PEER-DEP",
7778
"@angular/localize": "0.0.0-ANGULAR-FW-PEER-DEP",
7879
"@angular/platform-browser": "0.0.0-ANGULAR-FW-PEER-DEP",
@@ -90,6 +91,9 @@
9091
"typescript": ">=5.8 <5.9"
9192
},
9293
"peerDependenciesMeta": {
94+
"@angular/core": {
95+
"optional": true
96+
},
9397
"@angular/localize": {
9498
"optional": true
9599
},

Diff for: tests/legacy-cli/e2e/tests/misc/dedupe-duplicate-modules.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export default async function () {
1111
await updateJsonFile('package.json', (json) => {
1212
json.dependencies = {
1313
...json.dependencies,
14-
'tslib': '2.0.0',
14+
'tslib': '^2.0.0',
1515
'tslib-1': 'npm:[email protected]',
1616
'tslib-1-copy': 'npm:[email protected]',
1717
};
@@ -56,7 +56,7 @@ export default async function () {
5656
throw new Error('Expected stderr to contain [DedupeModuleResolvePlugin] log for tslib.');
5757
}
5858

59-
await expectFileToMatch(outFile, './node_modules/tslib/tslib.es6.js');
59+
await expectFileToMatch(outFile, './node_modules/tslib/tslib.es6.mjs');
6060
} finally {
6161
await rimraf('node_modules/tslib');
6262
await gitClean();

0 commit comments

Comments
 (0)