Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 11d9ad1

Browse files
authored
fix(ngTouch): remove ngClick override, $touchProvider, and $touch
Closes #15761 Closes #15755 BREAKING CHANGE: The `ngClick` directive from the ngTouch module has been removed, and with it the corresponding `$touchProvider` and `$touch` service. If you have included ngTouch v1.5.0 or higher in your application, and have not changed the value of `$touchProvider.ngClickOverrideEnabled()`, or injected and used the `$touch` service, then there are no migration steps for your code. Otherwise you must remove references to the provider and service. The `ngClick` override directive had been deprecated and by default disabled since v1.5.0, because of buggy behavior in edge cases, and a general trend to avoid special touch based overrides of click events. In modern browsers, it should not be necessary to use a touch override library: - Chrome, Firefox, Edge, and Safari remove the 300ms delay when `<meta name="viewport" content="width=device-width">` is set. - Internet Explorer 10+, Edge, Safari, and Chrome remove the delay on elements that have the `touch-action` css property is set to `manipulation`. You can find out more in these articles: https://developers.google.com/web/updates/2013/12/300ms-tap-delay-gone-away https://developer.apple.com/library/content/releasenotes/General/WhatsNewInSafari/Articles/Safari_9_1.html#//apple_ref/doc/uid/TP40014305-CH10-SW8 https://blogs.msdn.microsoft.com/ie/2015/02/24/pointer-events-w3c-recommendation-interoperable-touch-and-removing-the-dreaded-300ms-tap-delay/
1 parent 5a13cac commit 11d9ad1

File tree

5 files changed

+3
-1154
lines changed

5 files changed

+3
-1154
lines changed

Diff for: angularFiles.js

-1
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,6 @@ var angularFiles = {
146146
'ngTouch': [
147147
'src/ngTouch/touch.js',
148148
'src/ngTouch/swipe.js',
149-
'src/ngTouch/directive/ngClick.js',
150149
'src/ngTouch/directive/ngSwipe.js'
151150
],
152151
'ngAria': [

Diff for: docs/content/misc/downloading.ngdoc

+1-1
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ The set of files included in each version directory are:
111111
* __`angular-route.js`__ — Routing and deep-linking services and directives for AngularJS apps.
112112
({@link module:ngRoute API docs})
113113
* __`angular-sanitize.js`__ — Functionality to sanitize HTML. ({@link module:ngSanitize API docs})
114-
* __`angular-touch.js`__ — Touch events and other helpers for touch-enabled devices.
114+
* __`angular-touch.js`__ — Touch events for touch-enabled devices.
115115
({@link module:ngTouch API docs})
116116

117117

Diff for: src/ngTouch/directive/ngClick.js

-298
This file was deleted.

0 commit comments

Comments
 (0)