Skip to content

Commit 7a6a2b2

Browse files
author
Artur Bać
committed
fix kdevelop settings invalid ptr dereference
1 parent 64a5cc4 commit 7a6a2b2

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

src/plugin_common/include/plugin_common.h

+3-5
Original file line numberDiff line numberDiff line change
@@ -67,14 +67,12 @@ namespace config_page
6767
};
6868

6969
template<aiprocess::backend_type_e>
70-
auto construct(KTextEditor::ConfigPage &, ui_t &, std::function<void()> const &) -> void;
70+
auto construct(KTextEditor::ConfigPage &, ui_t &, std::function<void()>) -> void;
7171

7272
extern template auto
73-
construct<aiprocess::backend_type_e::kdevelop>(KTextEditor::ConfigPage &, ui_t &, std::function<void()> const &)
74-
-> void;
73+
construct<aiprocess::backend_type_e::kdevelop>(KTextEditor::ConfigPage &, ui_t &, std::function<void()>) -> void;
7574
extern template auto
76-
construct<aiprocess::backend_type_e::kate>(KTextEditor::ConfigPage &, ui_t &, std::function<void()> const &)
77-
-> void;
75+
construct<aiprocess::backend_type_e::kate>(KTextEditor::ConfigPage &, ui_t &, std::function<void()>) -> void;
7876

7977
template<aiprocess::backend_type_e>
8078
auto apply(ui_t &) -> void;

src/plugin_common/plugin_common.cc

+8-6
Original file line numberDiff line numberDiff line change
@@ -162,13 +162,15 @@ namespace config_page
162162
};
163163

164164
template<aiprocess::backend_type_e backend>
165-
auto construct(KTextEditor::ConfigPage & w, ui_t & ui, std::function<void()> const & emit_chnaged) -> void
165+
auto construct(KTextEditor::ConfigPage & w, ui_t & ui, std::function<void()> emit_changed) -> void
166166
{
167+
aiprocess::debug("construct() called");
167168
QVBoxLayout * main_layout = new QVBoxLayout(&w);
168169
QTabWidget * ai_tab_widget = new QTabWidget(&w);
169170
main_layout->addWidget(ai_tab_widget);
170171

171-
auto emit_changed = [&]<typename... Args>(Args &&...) { emit_chnaged(); };
172+
// auto emit_changed = [&]() { pemit_chnaged(); };
173+
// auto emit_changed = [&]<typename... Args>(Args &&...) { pemit_chnaged(); };
172174

173175
// Create a widget to hold the form layout
174176
QWidget * ai_form_widget = new QWidget();
@@ -218,14 +220,13 @@ namespace config_page
218220

219221
ai_tab_widget->addTab(log_form_widget, i18n("Logging"));
220222
reset<backend>(ui);
223+
aiprocess::debug("construct() end");
221224
}
222225

223226
template auto
224-
construct<aiprocess::backend_type_e::kdevelop>(KTextEditor::ConfigPage &, ui_t &, std::function<void()> const &)
225-
-> void;
227+
construct<aiprocess::backend_type_e::kdevelop>(KTextEditor::ConfigPage &, ui_t &, std::function<void()>) -> void;
226228
template auto
227-
construct<aiprocess::backend_type_e::kate>(KTextEditor::ConfigPage &, ui_t &, std::function<void()> const &)
228-
-> void;
229+
construct<aiprocess::backend_type_e::kate>(KTextEditor::ConfigPage &, ui_t &, std::function<void()>) -> void;
229230

230231
template<aiprocess::backend_type_e backend>
231232
auto apply(ui_t & ui) -> void
@@ -249,6 +250,7 @@ namespace config_page
249250
.important_log_level = level_enum(ui.important_log_level_combo->currentIndex()),
250251
.activation_keys = ui.activation_keys_spin->value()
251252
});
253+
aiprocess::debug("apply() end");
252254
}
253255

254256
template auto apply<aiprocess::backend_type_e::kdevelop>(ui_t &) -> void;

0 commit comments

Comments
 (0)