Skip to content

Commit 9cf0ac0

Browse files
committed
fix: ensure ssl verification happens with async client
gql recently had an issue reported where SSL connections are not verified by default: graphql-python/gql#529 They're planning to make it the default behaviour in their next release, but we should ensure SSL verification happens in the meantime.
1 parent 5667abd commit 9cf0ac0

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Diff for: pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ classifiers = [
2020
requires-python = ">=3.8"
2121
dependencies = [
2222
"aiohttp[speedups]~=3.8",
23-
"gql[aiohttp,requests]~=3.4",
23+
"gql[aiohttp,requests]>=3.5.1,<4",
2424
"pyjwt[crypto]~=2.8",
2525
"requests~=2.31",
2626
]

Diff for: src/simple_github/client.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ async def _get_gql_session(self) -> ReconnectingAsyncClientSession:
248248
if token:
249249
headers["Authorization"] = f"Bearer {token}"
250250

251-
transport = AIOHTTPTransport(url=GITHUB_GRAPHQL_ENDPOINT, headers=headers)
251+
transport = AIOHTTPTransport(url=GITHUB_GRAPHQL_ENDPOINT, headers=headers, ssl=True)
252252
self._gql_client = GqlClient(
253253
transport=transport, fetch_schema_from_transport=False
254254
)

0 commit comments

Comments
 (0)