-
Notifications
You must be signed in to change notification settings - Fork 23
Use web workflow port to connect to the board #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I was wondering about that, hence #29. |
I swear I looked at the issues and missed it somehow 🤦 I'm not setup to test locally, would changing from web-editor/assets/js/workflows/web.js Lines 105 to 109 in 7537516
|
I was thinking of just setting up a couple of devices and changing the port to something besides 80 and seeing what happens when I go to http://circuitpython.local |
The error message that the person is running into is thrown here: https://github.com/circuitpython/web-editor/blob/main/assets/js/workflows/web.js#L146. There are likely several places that need fixing for alternate ports to work. |
Yep, that's basically the fix. For some reason I was thinking there was extra stuff in host (like the protocol), but after looking it up just now, that would have been better than my solution. |
The web workflow doesn't take into account the board's port, and always tries to connect to 80.
When the board is configured uses a different port, it can't connect back to it. (
CIRCUITPY_WEB_API_PORT
)(from adafruit/circuitpython#7168 )
The text was updated successfully, but these errors were encountered: