Bring the coverage up again

Author: nils-braun

dask_sql/physical/rel/logical/sort.py

@@ -24,14 +24,13 @@ def convert(
             for x in sort_collation
         ]
 
-        if sort_columns:
-            ASCENDING = org.apache.calcite.rel.RelFieldCollation.Direction.ASCENDING
-            FIRST = org.apache.calcite.rel.RelFieldCollation.NullDirection.FIRST
-            sort_ascending = [x.getDirection() == ASCENDING for x in sort_collation]
-            sort_null_first = [x.nullDirection == FIRST for x in sort_collation]
-
-            df = df.persist()
-            df = apply_sort(df, sort_columns, sort_ascending, sort_null_first)
+        ASCENDING = org.apache.calcite.rel.RelFieldCollation.Direction.ASCENDING
+        FIRST = org.apache.calcite.rel.RelFieldCollation.NullDirection.FIRST
+        sort_ascending = [x.getDirection() == ASCENDING for x in sort_collation]
+        sort_null_first = [x.nullDirection == FIRST for x in sort_collation]
+
+        df = df.persist()
+        df = apply_sort(df, sort_columns, sort_ascending, sort_null_first)
 
         cc = self.fix_column_to_row_type(cc, rel.getRowType())
         # No column type has changed, so no need to cast again

dask_sql/physical/rex/core/call.py

@@ -162,12 +162,13 @@ def div(self, lhs, rhs):
         # For some reasons, Calcite decides to represent
         # 1000µs as 1000µs * 1000 / 1000
         # We do not need to truncate in this case
+        # So far, I did not spot any other occurrence
+        # of this function.
         if isinstance(result, datetime.timedelta):
             return result
-
-        result = da.trunc(result)
-
-        return result
+        else:  # pragma: no cover
+            result = da.trunc(result)
+            return result
 
 
 class CaseOperation(Operation):
@@ -215,7 +216,7 @@ def __init__(self):
         super().__init__(self.cast)
 
     def cast(self, operand, rex=None) -> SeriesOrScalar:
-        if not is_frame(operand):
+        if not is_frame(operand):  # pragma: no cover
             return operand
 
         output_type = str(rex.getType())