Skip to content

Commit 743274d

Browse files
committed
Added missing name field to ForeignKeySourceSerializer
1 parent 6ec7ad4 commit 743274d

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed

Diff for: tests/serializers.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,10 @@ class ForeignKeySourceSerializer(serializers.ModelSerializer):
2626

2727
class Meta:
2828
model = ForeignKeySource
29-
fields = ("target",)
29+
fields = (
30+
"name",
31+
"target",
32+
)
3033

3134

3235
class ManyToManyTargetSerializer(serializers.ModelSerializer):

Diff for: tests/test_relations.py

+10-3
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,9 @@ def test_serialize(
3939
settings.JSON_API_FORMAT_TYPES = format_type
4040
settings.JSON_API_PLURALIZE_TYPES = pluralize_type
4141

42-
serializer = ForeignKeySourceSerializer(instance={"target": foreign_key_target})
42+
serializer = ForeignKeySourceSerializer(
43+
instance={"target": foreign_key_target, "name": "Test"}
44+
)
4345
expected = {
4446
"type": resource_type,
4547
"id": str(foreign_key_target.pk),
@@ -85,7 +87,10 @@ def test_deserialize(
8587
settings.JSON_API_PLURALIZE_TYPES = pluralize_type
8688

8789
serializer = ForeignKeySourceSerializer(
88-
data={"target": {"type": resource_type, "id": str(foreign_key_target.pk)}}
90+
data={
91+
"target": {"type": resource_type, "id": str(foreign_key_target.pk)},
92+
"name": "Test",
93+
}
8994
)
9095

9196
assert serializer.is_valid()
@@ -191,7 +196,9 @@ def test_deserialize_many_to_many_relation(
191196
],
192197
)
193198
def test_invalid_resource_id_object(self, resource_identifier, error):
194-
serializer = ForeignKeySourceSerializer(data={"target": resource_identifier})
199+
serializer = ForeignKeySourceSerializer(
200+
data={"target": resource_identifier, "name": "Test"}
201+
)
195202
assert not serializer.is_valid()
196203
assert serializer.errors == {"target": [error]}
197204

0 commit comments

Comments
 (0)