System/Collections must not appear in JNI method signatures

[jonpryor]

Android framework version

net8.0-android, net9.0-android, Other

Affected platform version

All

Description

The string LSystem/Collections must not appear within JNI Method Signatures, because that is not the beginning of a valid Java type.

The current offender:

android-libraries/source/androidx.media3/media3-exoplayer/Additions/AndroidX.Media3.ExoPlayer.IExoPlayer.cs

Line 34 in 8305dd0

id_addMediaItems_ILSystem_Collections_Generic_IList_1_ = JNIEnv.GetMethodID (class_ref, "addMediaItems", "(ILSystem/Collections/Generic/IList<global::AndroidX.Media3.Common.MediaItem>;)V");

The fact that such methods are mentioned in a Transforms.xml is also not encouraging:

android-libraries/source/androidx.media3/media3-exoplayer/Transforms/Metadata.xml

Lines 7 to 14 in 8305dd0

	androidx/media3/common/Player.addMediaItems(ILSystem/Collections/Generic/IList`1;)V
	androidx/media3/common/Player.addMediaItems(LSystem/Collections/Generic/IList`1;)V
	androidx/media3/common/Player.setMediaItems(LSystem/Collections/Generic/IList`1;)V
	androidx/media3/common/Player.setMediaItems(LSystem/Collections/Generic/IList`1;Z)V
	androidx/media3/common/Player.setMediaItems(LSystem/Collections/Generic/IList`1;IJ)V
	androidx/media3/common/Player.setMediaItems(LSystem/Collections/Generic/IList`1;IJ)V
	androidx/media3/common/Player.replaceMediaItems(IILSystem/Collections/Generic/IList`1;)V
	androidx/media3/exoplayer/ExoPlayer.replaceMediaItems(IILjava/util/List;)V

JNI method signatures must only reference Java types. Failure to do so means the Java method cannot be resolved at runtime, which will result in exceptions at runtime:

@ne0rrmatrix: It looks like in Media3 SetMediaItems and AddMediaItems is not working.

 Java.Lang.NoSuchMethodError: 'no non-static method "Landroidx/media3/exoplayer/ExoPlayerImpl;.setMediaItems(LSystem/Collections/Generic/IList<global::AndroidX.Media3.Common.MediaItem>;)V"'

Relevant log output

[jonpryor]

I believe (hope?) that this will be implicitly fixed as part of #1058.