-
Notifications
You must be signed in to change notification settings - Fork 5k
Exclude System.IO.Compression async tests from wasm #114769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Tagging subscribers to 'arch-wasm': @lewing |
Tagging subscribers to this area: @dotnet/area-system-io-compression |
Why are the zip file tests ever blocking on monitors? Which tests? |
I see some of them quoted in the issue. This isn't an issue with wasm, it's an issue at a minimum with how the tests are written, e.g. MemoryStream stream = PopulateStream().Result instead of MemoryStream stream = await PopulateStream(); |
Oh, that's it. I couldn't find that I did learn about |
The newly added async tests in System.IO.Compression and System.IO.Compression.ZipFile are passing in all platforms and architectures except in the wasm libraries tests. They throw 'PlatformNotSupportedException' with the message 'Cannot wait on monitors on this runtime' which seems to be due to async tests not playing nicely in a single threaded environment.
Because I modified the existing tests so they would run the sync and async code depending on the boolean argument, both sync and async tests are currently failing in those wasm platforms.
The fix would be to split the async tests from the sync tests and either excluding the async tests from wasm or finding a way for them to run without issues in wasm.
Build Information
Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1019196
Build error leg or test failing: System.IO.Compression async tests
Error Message
browser-wasm linux Release LibraryTests
browser-wasm windows Release LibraryTests
browser-wasm linux Release LibraryTests_EAT
Known issue validation
Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=1019196
Error message validated:
[Cannot wait on monitors on this runtime at System.IO.Compression.Tests
]Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 4/17/2025 9:56:24 AM UTC
Report
Summary
Known issue validation
Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=1019196
Error message validated:
[Cannot wait on monitors on this runtime
]Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 4/17/2025 7:30:03 PM UTC
Report
Summary
Report
Summary
The text was updated successfully, but these errors were encountered: