Skip to content

Language picker: Add identifying feature and remove/fix duplicate nav ids #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrisdel101 opened this issue Feb 22, 2025 · 4 comments
Labels
design Change, update, or fix for site UI (not content) enhancement help wanted

Comments

@chrisdel101
Copy link
Contributor

The language picker needs to be more distinguishable announcing it as a page feature and not just some text. As it is it just looks like text to me. Could be as simple as some kind of border, or fancier with an arrow

Image

Also it has duplicate ids to navbar. These should be replaced, or changed to classes if they are reusing styles.

  • Ids should not be duplicated in a codebase normally
  • it's very confusing to see these navbar and navmenu identifiers inside the picker like this.
@chrisdel101 chrisdel101 added design Change, update, or fix for site UI (not content) ideas low priority labels Feb 22, 2025
@chrisdel101
Copy link
Contributor Author

Look like these issue are occurring in conjunction with #1780. Closing it for now since it's not appearing in the main branch after all. Will reopen later.

@carlosstenzel
Copy link
Contributor

I like the idea of icons next to each language.

@ShubhamOulkar
Copy link
Member

ShubhamOulkar commented Mar 21, 2025

Duplicate ID resolved in PR #1833 for the desktop language picker. The mobile language picker is not resolved because I am doing an accessibility fix there. However, I believe we can use the same component on mobile devices to remove some JS and CSS.

@carlosstenzel , I decided not to add icons in pr #1833 because of system/browsers restrictions. Ofcourse we can use svgs but it is not top priority at the moment.

@carlosstenzel
Copy link
Contributor

I think I could use SVG and hide it from mobile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Change, update, or fix for site UI (not content) enhancement help wanted
Projects
None yet
Development

No branches or pull requests

4 participants