You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The language picker needs to be more distinguishable announcing it as a page feature and not just some text. As it is it just looks like text to me. Could be as simple as some kind of border, or fancier with an arrow
Also it has duplicate ids to navbar. These should be replaced, or changed to classes if they are reusing styles.
Ids should not be duplicated in a codebase normally
it's very confusing to see these navbar and navmenu identifiers inside the picker like this.
The text was updated successfully, but these errors were encountered:
Look like these issue are occurring in conjunction with #1780. Closing it for now since it's not appearing in the main branch after all. Will reopen later.
Duplicate ID resolved in PR #1833 for the desktop language picker. The mobile language picker is not resolved because I am doing an accessibility fix there. However, I believe we can use the same component on mobile devices to remove some JS and CSS.
@carlosstenzel , I decided not to add icons in pr #1833 because of system/browsers restrictions. Ofcourse we can use svgs but it is not top priority at the moment.
The language picker needs to be more distinguishable announcing it as a page feature and not just some text. As it is it just looks like text to me. Could be as simple as some kind of border, or fancier with an arrow
Also it has duplicate ids to navbar. These should be replaced, or changed to classes if they are reusing styles.
navbar
andnavmenu
identifiers inside the picker like this.The text was updated successfully, but these errors were encountered: