Skip to content

bug: Lazy Health needs to add .bat to detect luarocks on Windows #1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
frostspanner opened this issue Jan 24, 2025 · 4 comments
Closed
4 tasks done

bug: Lazy Health needs to add .bat to detect luarocks on Windows #1902

frostspanner opened this issue Jan 24, 2025 · 4 comments
Labels
bug Something isn't working stale

Comments

@frostspanner
Copy link

frostspanner commented Jan 24, 2025

Did you check docs and existing issues?

  • I have read all the lazy.nvim docs
  • I have updated the plugin to the latest version before submitting this issue
  • I have searched the existing issues of lazy.nvim
  • I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

0.10.3

Operating system/version

Windows 11

Describe the bug

On my computer Lazy health returns

Image

even though Luarocks is installed and on path.

If I change

ok = Health.have("luarocks", opts)
to pass "luarocks.bat" to Health.have() following
if Util.is_win then
luarocks = luarocks .. ".bat"
Lazy correctly detects the installed version.

Steps To Reproduce

  1. Install luarocks on Windows
  2. Run neovim using minimal repro below
  3. Run Lazy health

Expected Behavior

Lazy health detects installed Luarocks

Repro

vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

require("lazy.minit").repro({
  spec = {
    -- add any other plugins here
  },
})
@frostspanner frostspanner added the bug Something isn't working label Jan 24, 2025
@frostspanner
Copy link
Author

frostspanner commented Jan 27, 2025

Building a plugin with a luarock (benlubas/neorg-query for me) also fails with lazy.nvim unable to spawn a luarocks process. Adding .bat here works as well.

ok = task:spawn(luarocks, {

e: found another:

local ok = task:spawn(luarocks, {

Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Feb 27, 2025
Copy link
Contributor

github-actions bot commented Mar 6, 2025

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2025
@TheZoc
Copy link

TheZoc commented Apr 20, 2025

#1983 fixes this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

2 participants