Skip to content

Commit 1e794f9

Browse files
author
Stewart Miles
committed
Made name of the plugin consistent across data collection dialogs.
Change-Id: Ied9db74bbcdcc9781ef2375cc0569c4ccd966878
1 parent aa3f37a commit 1e794f9

File tree

4 files changed

+11
-7
lines changed

4 files changed

+11
-7
lines changed

Diff for: source/AndroidResolver/src/PlayServicesResolver.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -750,8 +750,8 @@ public class AndroidBuildSystemChangedArgs : EventArgs {
750750
// Analytics reporter.
751751
internal static EditorMeasurement analytics = new EditorMeasurement(
752752
GooglePlayServices.SettingsDialog.projectSettings, logger,
753-
VersionHandlerImpl.GA_TRACKING_ID, "com.google.external-dependency-manager",
754-
"Android Resolver", "", VersionHandlerImpl.PRIVACY_POLICY) {
753+
VersionHandlerImpl.GA_TRACKING_ID, VersionHandlerImpl.MEASUREMENT_ID,
754+
VersionHandlerImpl.PLUGIN_SUITE_NAME, "", VersionHandlerImpl.PRIVACY_POLICY) {
755755
BasePath = "/androidresolver/",
756756
BaseQuery = String.Format("version={0}", AndroidResolverVersionNumber.Value.ToString()),
757757
BaseReportName = "Android Resolver: ",

Diff for: source/IOSResolver/src/IOSResolver.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -989,7 +989,7 @@ private delegate void LogMessageDelegate(string message, bool verbose = false,
989989
// Analytics reporter.
990990
internal static EditorMeasurement analytics = new EditorMeasurement(
991991
settings, logger, VersionHandlerImpl.GA_TRACKING_ID,
992-
"com.google.external-dependency-manager", "iOS Resolver", "",
992+
VersionHandlerImpl.MEASUREMENT_ID, VersionHandlerImpl.PLUGIN_SUITE_NAME, "",
993993
VersionHandlerImpl.PRIVACY_POLICY) {
994994
BasePath = "/iosresolver/",
995995
BaseQuery = String.Format("version={0}", IOSResolverVersionNumber.Value.ToString()),

Diff for: source/PackageManagerResolver/src/PackageManagerResolver.cs

+3-2
Original file line numberDiff line numberDiff line change
@@ -507,8 +507,9 @@ internal static void RestoreDefaultSettings() {
507507
// Analytics reporter.
508508
internal static EditorMeasurement analytics =
509509
new EditorMeasurement(settings, logger, VersionHandlerImpl.GA_TRACKING_ID,
510-
"com.google.external-dependency-manager", PLUGIN_NAME, "",
511-
VersionHandlerImpl.PRIVACY_POLICY) {
510+
VersionHandlerImpl.MEASUREMENT_ID,
511+
VersionHandlerImpl.PLUGIN_SUITE_NAME, "",
512+
VersionHandlerImpl.PRIVACY_POLICY) {
512513
BasePath = "/upmresolver/",
513514
BaseQuery =
514515
String.Format("version={0}", PackageManagerResolverVersionNumber.Value.ToString()),

Diff for: source/VersionHandlerImpl/src/VersionHandlerImpl.cs

+5-2
Original file line numberDiff line numberDiff line change
@@ -2263,13 +2263,16 @@ public static Logger Logger {
22632263

22642264
// Google Analytics tracking ID.
22652265
internal const string GA_TRACKING_ID = "UA-54627617-3";
2266+
internal const string MEASUREMENT_ID = "com.google.external-dependency-manager";
2267+
// Name of the plugin suite.
2268+
internal const string PLUGIN_SUITE_NAME = "External Dependency Manager";
22662269
// Privacy policy for analytics data usage.
22672270
internal const string PRIVACY_POLICY = "https://policies.google.com/privacy";
22682271

22692272
// Analytics reporter.
22702273
internal static EditorMeasurement analytics = new EditorMeasurement(
2271-
settings, logger, GA_TRACKING_ID, "com.google.external-dependency-manager",
2272-
"Version Handler", "", PRIVACY_POLICY) {
2274+
settings, logger, GA_TRACKING_ID, MEASUREMENT_ID, PLUGIN_SUITE_NAME, "",
2275+
PRIVACY_POLICY) {
22732276
BasePath = "/versionhandler/",
22742277
BaseQuery = String.Format("version={0}", VersionHandlerVersionNumber.Value.ToString()),
22752278
BaseReportName = "Version Handler: ",

0 commit comments

Comments
 (0)