Skip to content

Commit 10c8bef

Browse files
jberrymanhasura-bot
authored andcommitted
fix "unknown field used in output permissions" message to "input" (#1863)
Context: https://app.slack.com/client/T7GHF0SM9/C08PAUZG6F6 aside: this error message (or maybe it's `UnknownFieldInOutputPermissionsDefinition`) wasn't visible to the user. I couldn't immediately see how ErrorVisibility ultimately gets set for this type. Also looking at `set_span_attributes` it seems we don't have a mechanism for surfacing non-internal errors that end up in an internal span, is that what we want? If it is, should I make `build_metadata` user-visible? https://prod-gcp-grafana.hasura.io/d/a0aabf5f-9eb1-467b-8f5d-b7746a33c2a2/view-trace?orgId=1&var-traceId=1e444531ec996c040799e8ea9990de2b&from=now-6h&to=now&timezone=browser V3_GIT_ORIGIN_REV_ID: 28d76ac421a60994ef439f879794cc5e82af0e1f
1 parent c8dc683 commit 10c8bef

File tree

1 file changed

+1
-1
lines changed
  • v3/crates/metadata-resolve/src/stages/type_permissions

1 file changed

+1
-1
lines changed

v3/crates/metadata-resolve/src/stages/type_permissions/error.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ pub enum TypeInputPermissionError {
4141
"unsupported type in input type permissions definition: {type_name:}; only object types are supported"
4242
)]
4343
UnsupportedTypeInInputPermissions { type_name: CustomTypeName },
44-
#[error("unknown field '{field_name:}' used in output permissions of type '{type_name:}'")]
44+
#[error("unknown field '{field_name:}' used in input permissions of type '{type_name:}'")]
4545
UnknownFieldInInputPermissionsDefinition {
4646
field_name: FieldName,
4747
type_name: CustomTypeName,

0 commit comments

Comments
 (0)