Skip to content

Commit d798b2f

Browse files
committed
Build: Make browser tests correctly run on multiple jQuery versions
There was a typo in `jtr-local.yml`, making the runs using it load with a huge query string containing all the jQuery versions listed joined. Also, only IE and Safari runs even tried to use this config - the default run was not even reading the BROWSERS env variable. This all meant only one jQuery version was actually tested. Ref gh-576
1 parent 0ea1015 commit d798b2f

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

Diff for: .github/workflows/browser-tests.yml

+4-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,10 @@ jobs:
4343
run: npm install
4444

4545
- name: Run tests
46-
run: npm run test:browser -- -f plugin=${{ matrix.MIGRATE_VERSION }}
46+
run: |
47+
npm run pretest
48+
npm run test:unit -- -c jtr-local.yml \
49+
--headless -b ${{ matrix.BROWSER }} -f plugin=${{ matrix.MIGRATE_VERSION }}
4750
4851
ie:
4952
runs-on: windows-latest

Diff for: jtr-local.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
version: 1
22

3-
flags:
3+
runs:
44
jquery:
55
- git
66
- git.min

0 commit comments

Comments
 (0)