Update

Author: kubawerlos

README.md

@@ -5,7 +5,7 @@
 [![Latest stable version](https://img.shields.io/packagist/v/kubawerlos/php-cs-fixer-custom-fixers.svg?label=current%20version)](https://packagist.org/packages/kubawerlos/php-cs-fixer-custom-fixers)
 [![PHP version](https://img.shields.io/packagist/php-v/kubawerlos/php-cs-fixer-custom-fixers.svg)](https://php.net)
 [![License](https://img.shields.io/github/license/kubawerlos/php-cs-fixer-custom-fixers.svg)](LICENSE)
-![Tests](https://img.shields.io/badge/tests-3635-brightgreen.svg)
+![Tests](https://img.shields.io/badge/tests-3637-brightgreen.svg)
 [![Downloads](https://img.shields.io/packagist/dt/kubawerlos/php-cs-fixer-custom-fixers.svg)](https://packagist.org/packages/kubawerlos/php-cs-fixer-custom-fixers)
 
 [![CI status](https://github.com/kubawerlos/php-cs-fixer-custom-fixers/actions/workflows/ci.yaml/badge.svg)](https://github.com/kubawerlos/php-cs-fixer-custom-fixers/actions/workflows/ci.yaml)
@@ -407,7 +407,7 @@ There must be no useless write visibility.
 -    public(set) $y;
 -    protected protected(set) $z;
 +    public $x;
-+    public(set)$y;
++    public $y;
 +    protected $z;
  }
 ```

src/Fixer/NoUselessWriteVisibilityFixer.php

@@ -32,13 +32,13 @@ public function getDefinition(): FixerDefinitionInterface
             'There must be no useless write visibility.',
             [new CodeSample(
                 <<<'PHP'
-<?php class Foo {
-    public public(set) $x;
-    public(set) $y;
-    protected protected(set) $z;
-}
+                    <?php class Foo {
+                        public public(set) $x;
+                        public(set) $y;
+                        protected protected(set) $z;
+                    }
 
-PHP,
+                    PHP,
             )],
         );
     }
@@ -62,7 +62,7 @@ public function fix(\SplFileInfo $file, Tokens $tokens): void
     {
         foreach ($tokens->findGivenKind(\array_keys(self::PREDECESSOR_KIND_MAP)) as $kind => $elements) {
             foreach (\array_keys($elements) as $index) {
-                $this->fixVisibility($tokens, $index, $kind, \defined('T_PUBLIC_SET') && $kind === T_PUBLIC_SET);
+                self::fixVisibility($tokens, $index, $kind, $kind === \T_PUBLIC_SET);
             }
         }
     }
@@ -73,8 +73,9 @@ private static function fixVisibility(Tokens $tokens, int $index, int $kind, boo
 
         if (!$tokens[$prevIndex]->isGivenKind(self::PREDECESSOR_KIND_MAP[$kind])) {
             if ($makePublicIfNone) {
-                $tokens[$index] = new Token([T_PUBLIC, 'public']);
+                $tokens[$index] = new Token([\T_PUBLIC, 'public']);
             }
+
             return;
         }
 

tests/Fixer/NoUselessWriteVisibilityFixerTest.php

@@ -40,53 +40,53 @@ public static function provideFixCases(): iterable
     {
         yield [
             <<<'PHP'
-<?php class Foo {
-    public $x;
-    protected $z;
-    private $z;
-}
-PHP,
+                <?php class Foo {
+                    public $x;
+                    protected $z;
+                    private $z;
+                }
+                PHP,
             <<<'PHP'
-<?php class Foo {
-    public public(set) $x;
-    protected protected(set) $z;
-    private private(set) $z;
-}
-PHP,
+                <?php class Foo {
+                    public public(set) $x;
+                    protected protected(set) $z;
+                    private private(set) $z;
+                }
+                PHP,
         ];
 
         yield [
             <<<'PHP'
-<?php class Foo {
-    public $x;
-}
-PHP,
+                <?php class Foo {
+                    public $x;
+                }
+                PHP,
             <<<'PHP'
-<?php class Foo {
-    public(set) $x;
-}
-PHP,
+                <?php class Foo {
+                    public(set) $x;
+                }
+                PHP,
         ];
 
         yield [
             <<<'PHP'
-<?php class Foo {
-    public function __construct(
-        public $x,
-        protected $z,
-        private $z,
-    ) {}
-}
-PHP,
+                <?php class Foo {
+                    public function __construct(
+                        public $x,
+                        protected $z,
+                        private $z,
+                    ) {}
+                }
+                PHP,
             <<<'PHP'
-<?php class Foo {
-    public function __construct(
-        public public(set) $x,
-        protected protected(set) $z,
-        private private(set) $z,
-    ) {}
-}
-PHP,
+                <?php class Foo {
+                    public function __construct(
+                        public public(set) $x,
+                        protected protected(set) $z,
+                        private private(set) $z,
+                    ) {}
+                }
+                PHP,
         ];
     }
 }