fixed unit tests code coverage

Signed-off-by: Arashad Ahamad <[email protected]>

Author: arahamad

pkg/ibmcsidriver/controller.go

@@ -562,11 +562,8 @@ func (csiCS *CSIControllerServer) ListSnapshots(ctx context.Context, req *csi.Li
 	entries := []*csi.ListSnapshotsResponse_Entry{}
 	snapshotID := req.GetSnapshotId()
 	snapID, snapshotAccountID := getSnapshotAndAccountIDsFromCRN(snapshotID)
-
-	ctxLogger.Info("*****************************************", zap.Reflect("Node-ACCOUNTID", csiCS.Driver.accountID), zap.Reflect("SNAPHSOTID", snapshotAccountID))
-
-	if len(snapID) != 0 && csiCS.Driver.accountID == snapshotAccountID { // in case snapshotID's account and cluster account ID is same
-		if csiCS.Driver.accountID == snapshotAccountID {
+	if len(snapID) != 0 {
+		if csiCS.Driver.accountID == snapshotAccountID { // in case snapshotID's account and cluster account ID is same
 			snapshot, err := session.GetSnapshot(snapID)
 			if snapshot == nil {
 				return &csi.ListSnapshotsResponse{}, nil
@@ -597,7 +594,6 @@ func (csiCS *CSIControllerServer) ListSnapshots(ctx context.Context, req *csi.Li
 	}
 
 	maxEntries := int(req.GetMaxEntries())
-	ctxLogger.Info("******************************", zap.Reflect("SanpshotMAXENTRIES", req.GetMaxEntries()))
 	tags := map[string]string{}
 	sourceVolumeID := req.GetSourceVolumeId()
 	if len(sourceVolumeID) != 0 {

pkg/ibmcsidriver/controller_helper.go

@@ -472,7 +472,7 @@ func getAccountID(input string) string {
 	}
 }
 
-// getSnapshotIDFromCRN ...
+// getSnapshotAndAccountIDsFromCRN ...
 func getSnapshotAndAccountIDsFromCRN(crn string) (string, string) {
 	// This method will be able to handle either crn is actual crn or caller passed snapshot ID also
 	// expected CRN -> crn:v1:service:public:is:us-south:a/c468d8642937fecd8a0860fe0f379bf9::snapshot:r006-1234fe0c-3d9b-4c95-a6d1-8e0d4bcb6ecb

pkg/ibmcsidriver/controller_test.go

@@ -1474,6 +1474,14 @@ func TestListSnapshots(t *testing.T) {
 			expErrCode:        codes.OK,
 			libSnapshotError:  nil,
 		},
+		{
+			name:              "List snapshot with snapshotID as CRN",
+			snapshotID:        "crn:v1:staging:public:is:us-south:a/77f2bcedd73fe82c1c::snapshot:r134-1ad4-4852-b24a-b65050e42429",
+			expectedEntries:   1,
+			libGetSnapshotErr: false,
+			expErrCode:        codes.OK,
+			libSnapshotError:  nil,
+		},
 	}
 	timeNow := time.Now()
 	// Creating test logger