Skip to content

Commit 0ff1987

Browse files
killianmuldoonkillianmuldoon
authored
Make DNS Policy configurable in helm chart (#2025)
* Make DNS Policy configurable in helm chart Signed-off-by: Killian Muldoon <[email protected]> * Add documentation for helm dnsPolicy values Signed-off-by: Killian Muldoon <[email protected]> * Reformat tables in helm docs Signed-off-by: Killian Muldoon <[email protected]> --------- Signed-off-by: Killian Muldoon <[email protected]>
1 parent ab1bfd1 commit 0ff1987

File tree

6 files changed

+12
-3
lines changed

6 files changed

+12
-3
lines changed

‎deployment/helm/node-feature-discovery/templates/master.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ spec:
2929
{{- toYaml . | nindent 8 }}
3030
{{- end }}
3131
spec:
32+
dnsPolicy: {{ .Values.master.dnsPolicy }}
3233
{{- with .Values.priorityClassName }}
3334
priorityClassName: {{ . }}
3435
{{- end }}

‎deployment/helm/node-feature-discovery/templates/nfd-gc.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ spec:
2929
{{- end }}
3030
spec:
3131
serviceAccountName: {{ include "node-feature-discovery.gc.serviceAccountName" . }}
32-
dnsPolicy: ClusterFirstWithHostNet
32+
dnsPolicy: {{ .Values.gc.dnsPolicy }}
3333
{{- with .Values.priorityClassName }}
3434
priorityClassName: {{ . }}
3535
{{- end }}

‎deployment/helm/node-feature-discovery/templates/topologyupdater.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ spec:
2929
{{- end }}
3030
spec:
3131
serviceAccountName: {{ include "node-feature-discovery.topologyUpdater.serviceAccountName" . }}
32-
dnsPolicy: ClusterFirstWithHostNet
32+
dnsPolicy: {{ .Values.topologyUpdater.dnsPolicy }}
3333
{{- with .Values.priorityClassName }}
3434
priorityClassName: {{ . }}
3535
{{- end }}

‎deployment/helm/node-feature-discovery/templates/worker.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ spec:
2828
{{- toYaml . | nindent 8 }}
2929
{{- end }}
3030
spec:
31-
dnsPolicy: ClusterFirstWithHostNet
31+
dnsPolicy: {{ .Values.worker.dnsPolicy }}
3232
{{- with .Values.priorityClassName }}
3333
priorityClassName: {{ . }}
3434
{{- end }}

‎deployment/helm/node-feature-discovery/values.yaml

+4
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ master:
2020
extraArgs: []
2121
extraEnvs: []
2222
hostNetwork: false
23+
dnsPolicy: ClusterFirstWithHostNet
2324
config: ### <NFD-MASTER-CONF-START-DO-NOT-REMOVE>
2425
# noPublish: false
2526
# autoDefaultNs: true
@@ -173,6 +174,7 @@ worker:
173174
extraArgs: []
174175
extraEnvs: []
175176
hostNetwork: false
177+
dnsPolicy: ClusterFirstWithHostNet
176178
config: ### <NFD-WORKER-CONF-START-DO-NOT-REMOVE>
177179
#core:
178180
# labelWhiteList:
@@ -499,6 +501,7 @@ topologyUpdater:
499501
extraArgs: []
500502
extraEnvs: []
501503
hostNetwork: false
504+
dnsPolicy: ClusterFirstWithHostNet
502505

503506
serviceAccount:
504507
create: true
@@ -563,6 +566,7 @@ gc:
563566
extraEnvs: []
564567
hostNetwork: false
565568
replicaCount: 1
569+
dnsPolicy: ClusterFirstWithHostNet
566570

567571
serviceAccount:
568572
create: true

‎docs/deployment/helm.md

+4
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,7 @@ API's you need to install the prometheus operator in your cluster.
213213
| `master.readinessProbe.periodSeconds` | integer | 10 (by Kubernetes) | Specifies how often (in seconds) to perform the readiness probe. |
214214
| `master.readinessProbe.timeoutSeconds` | integer | 1 (by Kubernetes) | Specifies the number of seconds after which the probe times out. |
215215
| `master.readinessProbe.successThreshold` | integer | 1 (by Kubernetes) | Specifies the number of consecutive successes of readiness probes before considering the pod as ready. |
216+
| `master.dnsPolicy` | array | ClusterFirstWithHostNet | NFD master pod [dnsPolicy](https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-policy) |
216217

217218
> `[0]` Additional info for `master.resources.requests`: \
218219
> You may want to use the same value for `requests.memory` and `limits.memory`.
@@ -261,6 +262,7 @@ API's you need to install the prometheus operator in your cluster.
261262
| `worker.readinessProbe.periodSeconds` | integer | 10 (by Kubernetes) | Specifies how often (in seconds) to perform the readiness probe. |
262263
| `worker.readinessProbe.timeoutSeconds` | integer | 1 (by Kubernetes) | Specifies the number of seconds after which the probe times out. |
263264
| `worker.readinessProbe.successThreshold` | integer | 1 (by Kubernetes) | Specifies the number of consecutive successes of readiness probes before considering the pod as ready. |
265+
| `worker.dnsPolicy` | array | ClusterFirstWithHostNet | NFD worker pod [dnsPolicy](https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-policy) |
264266

265267
### Topology updater parameters
266268

@@ -304,6 +306,7 @@ API's you need to install the prometheus operator in your cluster.
304306
| `topologyUpdater.readinessProbe.periodSeconds` | integer | 10 (by Kubernetes) | Specifies how often (in seconds) to perform the readiness probe. |
305307
| `topologyUpdater.readinessProbe.timeoutSeconds` | integer | 1 (by Kubernetes) | Specifies the number of seconds after which the probe times out. |
306308
| `topologyUpdater.readinessProbe.successThreshold` | integer | 1 (by Kubernetes) | Specifies the number of consecutive successes of readiness probes before considering the pod as ready. |
309+
| `topologyUpdater.dnsPolicy` | array | ClusterFirstWithHostNet | Topology updater pod [dnsPolicy](https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-policy) |
307310

308311
### Garbage collector parameters
309312

@@ -329,6 +332,7 @@ API's you need to install the prometheus operator in your cluster.
329332
| `gc.extraArgs` | array | [] | Additional [command line arguments](../reference/gc-commandline-reference.md) to pass to nfd-gc |
330333
| `gc.extraEnvs` | array | [] | Additional environment variables to pass to nfd-gc |
331334
| `gc.revisionHistoryLimit` | integer | | Specify how many old ReplicaSets for this Deployment you want to retain. [revisionHistoryLimit](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#revision-history-limit) |
335+
| `gc.dnsPolicy` | array | ClusterFirstWithHostNet | Garbage collector pod [dnsPolicy](https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-policy) |
332336

333337
<!-- Links -->
334338

0 commit comments

Comments
 (0)