Merge pull request #134 from microsoft/benjaming/address-codeql

bgn64 · web-flow · commit ae19293fddd4 · 2025-03-17T10:43:19.000-07:00
Mark CodeQL exception
diff --git a/Utilities/Common.cs b/Utilities/Common.cs
@@ -39,7 +39,7 @@ public static Guid GenerateGuidFromName(string name)
             }
 
             // Compute the Sha1 hash 
-            var sha1 = SHA1.Create();
+            var sha1 = SHA1.Create(); // CodeQL [SM02196] False positive: this hash is not used for any sort of crytopgraphy
             byte[] hash = sha1.ComputeHash(bytes);
 
             // Create a GUID out of the first 16 bytes of the hash (SHA-1 create a 20 byte hash)

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ public static Guid GenerateGuidFromName(string name)`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`// Compute the Sha1 hash`
`42`		`- var sha1 = SHA1.Create();`
	`42`	`+ var sha1 = SHA1.Create(); // CodeQL [SM02196] False positive: this hash is not used for any sort of crytopgraphy`
`43`	`43`	`byte[] hash = sha1.ComputeHash(bytes);`
`44`	`44`
`45`	`45`	`// Create a GUID out of the first 16 bytes of the hash (SHA-1 create a 20 byte hash)`