Skip to content

[bug] support nulling out extended tsconfig.json properties #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mjames-c opened this issue Apr 8, 2025 · 1 comment
Open

[bug] support nulling out extended tsconfig.json properties #768

mjames-c opened this issue Apr 8, 2025 · 1 comment

Comments

@mjames-c
Copy link
Contributor

mjames-c commented Apr 8, 2025

simple repro:

// tsconfig.base.json
{
  "compilerOptions": {
    "types": []
  },
}

// tsconfig.json
{
  "compilerOptions": {
    "types": null
  },
  "extends": "./tsconfig.base.json"
}

then run the below and note that compilerOptions.types is still set to the empty array, [].

$ built/local/tsgo -p path/to/tsconfig.json -showConfig
{
  ...
  "types": [],
  ...
}
@jakebailey
Copy link
Member

This is a challenge in the Go code since we don't have two kinds of null anymore; I think we should have some sort of "unresolved" compiler options we use during load, which we then finalize into the final settings that don't need null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants