[chore] return by value (#741)

Co-authored-by: Pablo Baeyens <[email protected]>

Author: atoulme

checkapi/internal/ast.go

@@ -87,12 +87,12 @@ func ExprToString(expr ast.Expr) string {
 	}
 }
 
-func Read(folder string, ignoredFunctions []string, excludedFiles []string) (*API, error) {
+func Read(folder string, ignoredFunctions []string, excludedFiles []string) (API, error) {
 	result := &API{}
 	set := token.NewFileSet()
 	packs, err := parser.ParseDir(set, folder, nil, 0)
 	if err != nil {
-		return nil, err
+		return API{}, err
 	}
 
 	for _, pack := range packs {
@@ -101,7 +101,7 @@ func Read(folder string, ignoredFunctions []string, excludedFiles []string) (*AP
 			for _, exclusionPattern := range excludedFiles {
 				ok, err2 := filepath.Match(exclusionPattern, filepath.Base(path))
 				if err2 != nil {
-					return nil, err2
+					return API{}, err2
 				}
 				if ok {
 					continue FILE
@@ -111,7 +111,7 @@ func Read(folder string, ignoredFunctions []string, excludedFiles []string) (*AP
 		}
 	}
 
-	return result, nil
+	return *result, nil
 }
 
 func readFile(ignoredFunctions []string, f *ast.File, result *API) {
@@ -136,7 +136,7 @@ func readFile(ignoredFunctions []string, f *ast.File, result *API) {
 								}
 							}
 						}
-						result.Structs = append(result.Structs, &Apistruct{
+						result.Structs = append(result.Structs, Apistruct{
 							Name:   t.Name.String(),
 							Fields: fieldNames,
 						})
@@ -182,7 +182,7 @@ func readFile(ignoredFunctions []string, f *ast.File, result *API) {
 						typeParams = append(typeParams, ExprToString(r.Type))
 					}
 				}
-				f := &Function{
+				f := Function{
 					Name:        fn.Name.Name,
 					Receiver:    receiver,
 					Params:      params,

checkapi/internal/config.go

@@ -17,9 +17,9 @@ type Apistruct struct {
 }
 
 type API struct {
-	Values    []string     `json:"values,omitempty"`
-	Structs   []*Apistruct `json:"structs,omitempty"`
-	Functions []*Function  `json:"functions,omitempty"`
+	Values    []string    `json:"values,omitempty"`
+	Structs   []Apistruct `json:"structs,omitempty"`
+	Functions []Function  `json:"functions,omitempty"`
 }
 
 type FunctionDescription struct {

checkapi/main.go

@@ -143,7 +143,7 @@ func walkFolder(cfg internal.Config, folder string, componentType string) error
 	return errors.Join(errs...)
 }
 
-func checkStructDisallowUnkeyedLiteral(cfg internal.Config, s *internal.Apistruct, folder string) error {
+func checkStructDisallowUnkeyedLiteral(cfg internal.Config, s internal.Apistruct, folder string) error {
 	if !unicode.IsUpper(rune(s.Name[0])) {
 		return nil
 	}