Skip to content

Large and multiple scan optimization #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task
AchillesHeir opened this issue Jan 13, 2025 · 0 comments
Open
1 task

Large and multiple scan optimization #43

AchillesHeir opened this issue Jan 13, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@AchillesHeir
Copy link
Contributor

Description

There is a rate limit to using VirusTotal, which is 4 scans per minute. Currently the logic is covered by waiting 20 seconds for each file scan, but it's not the best solution as really large scans take longer than could be optimized and running another scan simultaneously will cause errors as it will exceed the rate limit.

Reproduction

The solution is most likely checking if a scan is currently in place and putting a hold if so, the other is listening for when files are done scanning to start a new one provided it's within the time limit.

System information

File is VirusTotalScan, but the invocation of the functionality is in the extension file.

Additional information

None

👨‍👧‍👦 Contributing

  • 🙋‍♂️ Yes, I'd love to make a PR to fix this bug!
@AchillesHeir AchillesHeir added the bug Something isn't working label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant