Skip to content

Commit d07a9a5

Browse files
Solve todo
1 parent 5e4e3d8 commit d07a9a5

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

src/Type/Accessory/HasPropertyType.php

+8-4
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,10 @@ public function accepts(Type $type, bool $strictTypes): AcceptsResult
7272

7373
public function isSuperTypeOf(Type $type): IsSuperTypeOfResult
7474
{
75-
// TODO
76-
return new IsSuperTypeOfResult($type->hasProperty($this->propertyName), []);
75+
return new IsSuperTypeOfResult(
76+
$type->hasInstanceProperty($this->propertyName)->or($type->hasStaticProperty($this->propertyName)),
77+
[],
78+
);
7779
}
7880

7981
public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult
@@ -88,8 +90,10 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult
8890
$limit = IsSuperTypeOfResult::createMaybe();
8991
}
9092

91-
// TODO
92-
return $limit->and(new IsSuperTypeOfResult($otherType->hasProperty($this->propertyName), []));
93+
return $limit->and(new IsSuperTypeOfResult(
94+
$otherType->hasInstanceProperty($this->propertyName)->or($otherType->hasStaticProperty($this->propertyName)),
95+
[],
96+
));
9397
}
9498

9599
public function isAcceptedBy(Type $acceptingType, bool $strictTypes): AcceptsResult

0 commit comments

Comments
 (0)