Skip to content

Update the keyboard shortcuts based on user preferences #3444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karanBRAVO opened this issue Apr 10, 2025 · 2 comments · May be fixed by #3445
Open

Update the keyboard shortcuts based on user preferences #3444

karanBRAVO opened this issue Apr 10, 2025 · 2 comments · May be fixed by #3445

Comments

@karanBRAVO
Copy link
Contributor

Increasing Access

Like in most of the editor(s), users can change the keymaps based on their preferences. There should also be a feature to in p5.js-web-editor to change the keyboard shortcuts as user likes.

Feature request details

  1. Add a edit button
  2. create context or redux slice for global state(s) mgmt
  3. track the keys using onKeyDown or onKeyUp, etc.
  4. Also ensure that shortcut don't clash with browser shortcuts
@karanBRAVO
Copy link
Contributor Author

I have added the PR to check the feasibility of this feature.

@raclim
Copy link
Collaborator

raclim commented Apr 10, 2025

Thanks for opening this @karanBRAVO, I think the idea is interesting!

Before adding new features, we generally like to gain some sort of discussion or consensus first among a few folks before starting developing on it. However, since you already have something down, I think it'd be great if you could share some screenshots or videos (either in the PR or here in this issue) of how it functions!

One note I might add though is that we're currently in the process of refactoring the Editor component for the CodeMirror 6 upgrade. You can reference the changes here to see what the component looks like so far. Since we're planning to integrate and work with these changes first, I might suggest waiting until that work is done before revisiting this feature.

karanBRAVO added a commit to karanBRAVO/p5.js-web-editor that referenced this issue Apr 11, 2025
This PR add more shortcuts to the map which
user can change.
karanBRAVO added a commit to karanBRAVO/p5.js-web-editor that referenced this issue Apr 11, 2025
karanBRAVO added a commit to karanBRAVO/p5.js-web-editor that referenced this issue Apr 11, 2025
This PR add more shortcuts to the map which
user can change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants