Skip to content

Define dependencies in a separate file #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m-aciek opened this issue Feb 18, 2025 · 3 comments
Open

Define dependencies in a separate file #66

m-aciek opened this issue Feb 18, 2025 · 3 comments

Comments

@m-aciek
Copy link
Collaborator

m-aciek commented Feb 18, 2025

We plan to have a second entrypoint script. Let's migrate from inline dependencies definition to a separate file.

@StanFromIreland
Copy link
Collaborator

What benefit does it have over a simple requirements.txt for the dashboard?

@m-aciek m-aciek changed the title pyproject.toml to define dependecies Define dependencies in a separate file Feb 19, 2025
@m-aciek
Copy link
Collaborator Author

m-aciek commented Feb 20, 2025

It follows the latest best practices. Though we'd need to start tracking version of dashboard, as minimal pyproject.toml would need to be as follow:

[project]
name = "pydocs-translations-dashboard"
version = "1"
dependencies = [
     "gitpython",
     "potodo",
     "jinja2",
     "docutils",
 ]

So I'm a bit torn, I've updated the ticket title and description not to decide yet.

@StanFromIreland
Copy link
Collaborator

It would have to be a bit longer.

The proposed throws:

Installing build dependencies ... done
  Getting requirements to build wheel ... error
  error: subprocess-exited-with-error
  
  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [14 lines of output]
      error: Multiple top-level modules discovered in a flat-layout: ['generate', 'repositories', 'completion', 'visitors', 'contribute', 'build_status', 'translators'].
      
      To avoid accidental inclusion of unwanted files or directories,
      setuptools will not proceed with this build.
      
      If you are trying to create a single distribution with multiple modules
      on purpose, you should not rely on automatic discovery.
      Instead, consider the following options:
      
      1. set up custom discovery (`find` directive with `include` or `exclude`)
      2. use a `src-layout`
      3. explicitly set `py_modules` or `packages` with a list of names
      
      To find more information, look for "package discovery" on setuptools docs.
      [end of output]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants