Skip to content

Commit 7e807cb

Browse files
committed
Core: Remove support for PhantomJS
Ref #1505.
1 parent 775c069 commit 7e807cb

File tree

3 files changed

+3
-16
lines changed

3 files changed

+3
-16
lines changed

src/globals.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ export const localSessionStorage = (function () {
6464
}());
6565

6666
// Basic fallback for ES6 Map
67-
// Support: Safari 7, PhantomJS; Map is undefined
67+
// Support: Safari 7; Map is undefined
6868
// Support: iOS 8; `new Map(iterable)` is not supported
6969
//
7070
// Fallback for ES7 Map#keys

src/html-reporter/html.js

+2-12
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import QUnit from '../core';
22
import { extend, errorString, escapeText } from '../core/utilities';
3-
import { window, document, navigator, console, StringMap } from '../globals';
3+
import { window, document, navigator, StringMap } from '../globals';
44
import fuzzysort from 'fuzzysort';
55

66
const stats = {
@@ -1068,17 +1068,7 @@ const stats = {
10681068
testItem.className = 'fail';
10691069
});
10701070

1071-
// Avoid readyState issue with phantomjs
1072-
// Ref: #818
1073-
const usingPhantom = (function (p) {
1074-
return (p && p.version && p.version.major > 0);
1075-
})(window.phantom);
1076-
1077-
if (usingPhantom) {
1078-
console.warn('Support for PhantomJS is deprecated and will be removed in QUnit 3.0.');
1079-
}
1080-
1081-
if (!usingPhantom && document.readyState === 'complete') {
1071+
if (document.readyState === 'complete') {
10821072
QUnit.autostart();
10831073
} else {
10841074
addEvent(window, 'load', QUnit.autostart);

test/reorder.js

-3
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@ QUnit.test('Second', function (assert) {
1515
assert.strictEqual(lastTest, '');
1616
lastTest = 'Second';
1717

18-
// For some reason PhantomJS mutates config.reorder
19-
QUnit.config.reorder = true;
20-
2118
// This test is "high priority" so it should execute before test "First"
2219
// even though it is added to the queue late
2320
// eslint-disable-next-line qunit/no-nested-tests

0 commit comments

Comments
 (0)