Skip to content

Commit 087f92f

Browse files
authored
Skip rabbit_mqtt_qos0_queue_kill_node in mixed version mode (#10210)
* Skip rabbit_mqtt_qos0_queue_kill_node in mixed version mode Follow up of #10205 Branch v3.12.x is currently red because test ``` bazel test //deps/rabbitmq_mqtt:shared_SUITE-mixed -t- --test_sharding_strategy=disabled --test_env FOCUS="-group [mqtt,cluster_size_3] -case rabbit_mqtt_qos0_queue_kill_node" ``` fails because the old node will error out with: ``` [info] <0.1962.0> accepting MQTT connection <0.1962.0> (127.0.0.1:61899 -> 127.0.0.1:21059, client id: subscriber) [debug] <0.1962.0> Received a SUBSCRIBE for topic(s) [{mqtt_topic, [debug] <0.1962.0> "rabbit_mqtt_qos0_queue_kill_node",0}] [error] <0.1977.0> Channel error on connection <0.1965.0> (127.0.0.1:61899 -> 127.0.0.1:21059, vhost: '/', user: 'guest'), channel 1: [error] <0.1977.0> operation queue.declare caused a channel exception resource_locked: cannot obtain exclusive access to locked queue 'mqtt-subscription-subscriberqos0' in vhost '/'. It could be originally declared on another connection or the exclusive property value does not match that of the original declaration. ``` Classic mirrored queue could be used instead as descibed in https://groups.google.com/g/rabbitmq-users/c/pxgy0QiwilM/m/LkJQ-3DyBgAJ PR #10205 specifically allows for clients to re-subscribe to a live node for queue type rabbit_mqtt_qos0_queue. So, it's okay to skip the test when run with feature flag rabbit_mqtt_qos0_queue being disabled causing a classic queue to be created. * Ensure test is skipped
1 parent d0ccd4f commit 087f92f

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

deps/rabbitmq_mqtt/test/shared_SUITE.erl

+6-1
Original file line numberDiff line numberDiff line change
@@ -102,14 +102,14 @@ subgroups() ->
102102
]},
103103
{cluster_size_3, [],
104104
[
105+
rabbit_mqtt_qos0_queue_kill_node,
105106
queue_down_qos1,
106107
consuming_classic_mirrored_queue_down,
107108
consuming_classic_queue_down,
108109
flow_classic_mirrored_queue,
109110
flow_quorum_queue,
110111
flow_stream,
111112
rabbit_mqtt_qos0_queue,
112-
rabbit_mqtt_qos0_queue_kill_node,
113113
cli_list_queues,
114114
maintenance,
115115
delete_create_queue,
@@ -174,6 +174,11 @@ end_per_group(_, Config) ->
174174
rabbit_ct_client_helpers:teardown_steps() ++
175175
rabbit_ct_broker_helpers:teardown_steps()).
176176

177+
init_per_testcase(rabbit_mqtt_qos0_queue_kill_node = T, Config) ->
178+
case rabbit_ct_broker_helpers:enable_feature_flag(Config, rabbit_mqtt_qos0_queue) of
179+
ok -> init_per_testcase0(T, Config);
180+
{skip, _} = Skip -> Skip
181+
end;
177182
init_per_testcase(T, Config)
178183
when T =:= management_plugin_connection;
179184
T =:= management_plugin_enable ->

0 commit comments

Comments
 (0)