From b1abb37cf0862c862b7a437dd63ff38bd3a9fe15 Mon Sep 17 00:00:00 2001 From: alinkedd Date: Tue, 20 Feb 2024 23:49:21 +0200 Subject: [PATCH 1/3] Fix warning of missing analysis comment artifact --- .github/workflows/analyze.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/analyze.yml b/.github/workflows/analyze.yml index 83e7f2e8a9c..09b20a00c12 100644 --- a/.github/workflows/analyze.yml +++ b/.github/workflows/analyze.yml @@ -84,6 +84,7 @@ jobs: - name: Upload analysis comment uses: actions/upload-artifact@v4 + if: success() && github.event.number with: name: analysis_comment.txt path: .next/analyze/__bundle_analysis_comment.txt From 541c257c37dca458620c0f36999d931b1f9f961c Mon Sep 17 00:00:00 2001 From: alinkedd Date: Tue, 20 Feb 2024 23:56:18 +0200 Subject: [PATCH 2/3] Fix comment action failing on default branch --- .github/workflows/analyze_comment.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/analyze_comment.yml b/.github/workflows/analyze_comment.yml index 1e086b9b704..d43380ba8bd 100644 --- a/.github/workflows/analyze_comment.yml +++ b/.github/workflows/analyze_comment.yml @@ -12,8 +12,8 @@ jobs: comment: runs-on: ubuntu-latest if: > - ${{ github.event.workflow_run.event == 'pull_request' && - github.event.workflow_run.conclusion == 'success' }} + github.event.workflow_run.event == 'pull_request' && + github.event.workflow_run.conclusion == 'success' steps: - name: Download base branch bundle stats uses: dawidd6/action-download-artifact@268677152d06ba59fcec7a7f0b5d961b6ccd7e1e From 0cd7454d75b69c93d5f14b3b8b469e98c30941e6 Mon Sep 17 00:00:00 2001 From: alinkedd Date: Mon, 14 Apr 2025 23:57:20 +0200 Subject: [PATCH 3/3] Fix comment action failing because of no permissions --- .github/workflows/analyze_comment.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/analyze_comment.yml b/.github/workflows/analyze_comment.yml index d43380ba8bd..5d3ce8c63ea 100644 --- a/.github/workflows/analyze_comment.yml +++ b/.github/workflows/analyze_comment.yml @@ -6,7 +6,8 @@ on: types: - completed -permissions: {} +permissions: + pull-requests: write jobs: comment: