Skip to content

Commit e5e3100

Browse files
SimonFringsSimonFrings
committed
Add native types to public API
1 parent f2fb5a2 commit e5e3100

8 files changed

+79
-79
lines changed

‎src/ExtEvLoop.php

+12-12
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ public function __construct()
7171
$this->signals = new SignalsHandler();
7272
}
7373

74-
public function addReadStream($stream, $listener)
74+
public function addReadStream($stream, callable $listener): void
7575
{
7676
$key = (int)$stream;
7777

@@ -97,7 +97,7 @@ private function getStreamListenerClosure($stream, $listener)
9797
};
9898
}
9999

100-
public function addWriteStream($stream, $listener)
100+
public function addWriteStream($stream, callable $listener): void
101101
{
102102
$key = (int)$stream;
103103

@@ -110,7 +110,7 @@ public function addWriteStream($stream, $listener)
110110
$this->writeStreams[$key] = $event;
111111
}
112112

113-
public function removeReadStream($stream)
113+
public function removeReadStream($stream): void
114114
{
115115
$key = (int)$stream;
116116

@@ -122,7 +122,7 @@ public function removeReadStream($stream)
122122
unset($this->readStreams[$key]);
123123
}
124124

125-
public function removeWriteStream($stream)
125+
public function removeWriteStream($stream): void
126126
{
127127
$key = (int)$stream;
128128

@@ -134,7 +134,7 @@ public function removeWriteStream($stream)
134134
unset($this->writeStreams[$key]);
135135
}
136136

137-
public function addTimer($interval, $callback)
137+
public function addTimer($interval, callable $callback): TimerInterface
138138
{
139139
$timer = new Timer($interval, $callback, false);
140140

@@ -152,7 +152,7 @@ public function addTimer($interval, $callback)
152152
return $timer;
153153
}
154154

155-
public function addPeriodicTimer($interval, $callback)
155+
public function addPeriodicTimer($interval, callable $callback): TimerInterface
156156
{
157157
$timer = new Timer($interval, $callback, true);
158158

@@ -166,7 +166,7 @@ public function addPeriodicTimer($interval, $callback)
166166
return $timer;
167167
}
168168

169-
public function cancelTimer(TimerInterface $timer)
169+
public function cancelTimer(TimerInterface $timer): void
170170
{
171171
if (!isset($this->timers[$timer])) {
172172
return;
@@ -177,12 +177,12 @@ public function cancelTimer(TimerInterface $timer)
177177
$this->timers->detach($timer);
178178
}
179179

180-
public function futureTick($listener)
180+
public function futureTick(callable $listener): void
181181
{
182182
$this->futureTickQueue->add($listener);
183183
}
184184

185-
public function run()
185+
public function run(): void
186186
{
187187
$this->running = true;
188188

@@ -207,7 +207,7 @@ public function run()
207207
}
208208
}
209209

210-
public function stop()
210+
public function stop(): void
211211
{
212212
$this->running = false;
213213
}
@@ -228,7 +228,7 @@ public function __destruct()
228228
}
229229
}
230230

231-
public function addSignal($signal, $listener)
231+
public function addSignal(int $signal, callable $listener): void
232232
{
233233
$this->signals->add($signal, $listener);
234234

@@ -239,7 +239,7 @@ public function addSignal($signal, $listener)
239239
}
240240
}
241241

242-
public function removeSignal($signal, $listener)
242+
public function removeSignal(int $signal, callable $listener): void
243243
{
244244
$this->signals->remove($signal, $listener);
245245

‎src/ExtEventLoop.php

+12-12
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ public function __destruct()
7171
$this->writeEvents = [];
7272
}
7373

74-
public function addReadStream($stream, $listener)
74+
public function addReadStream($stream, callable $listener): void
7575
{
7676
$key = (int) $stream;
7777
if (isset($this->readListeners[$key])) {
@@ -88,7 +88,7 @@ public function addReadStream($stream, $listener)
8888
$this->readRefs[$key] = $stream;
8989
}
9090

91-
public function addWriteStream($stream, $listener)
91+
public function addWriteStream($stream, callable $listener): void
9292
{
9393
$key = (int) $stream;
9494
if (isset($this->writeListeners[$key])) {
@@ -105,7 +105,7 @@ public function addWriteStream($stream, $listener)
105105
$this->writeRefs[$key] = $stream;
106106
}
107107

108-
public function removeReadStream($stream)
108+
public function removeReadStream($stream): void
109109
{
110110
$key = (int) $stream;
111111

@@ -119,7 +119,7 @@ public function removeReadStream($stream)
119119
}
120120
}
121121

122-
public function removeWriteStream($stream)
122+
public function removeWriteStream($stream): void
123123
{
124124
$key = (int) $stream;
125125

@@ -133,7 +133,7 @@ public function removeWriteStream($stream)
133133
}
134134
}
135135

136-
public function addTimer($interval, $callback)
136+
public function addTimer($interval, callable $callback): TimerInterface
137137
{
138138
$timer = new Timer($interval, $callback, false);
139139

@@ -142,7 +142,7 @@ public function addTimer($interval, $callback)
142142
return $timer;
143143
}
144144

145-
public function addPeriodicTimer($interval, $callback)
145+
public function addPeriodicTimer($interval, callable $callback): TimerInterface
146146
{
147147
$timer = new Timer($interval, $callback, true);
148148

@@ -151,20 +151,20 @@ public function addPeriodicTimer($interval, $callback)
151151
return $timer;
152152
}
153153

154-
public function cancelTimer(TimerInterface $timer)
154+
public function cancelTimer(TimerInterface $timer): void
155155
{
156156
if ($this->timerEvents->contains($timer)) {
157157
$this->timerEvents[$timer]->free();
158158
$this->timerEvents->detach($timer);
159159
}
160160
}
161161

162-
public function futureTick($listener)
162+
public function futureTick(callable $listener): void
163163
{
164164
$this->futureTickQueue->add($listener);
165165
}
166166

167-
public function addSignal($signal, $listener)
167+
public function addSignal(int $signal, callable $listener): void
168168
{
169169
$this->signals->add($signal, $listener);
170170

@@ -174,7 +174,7 @@ public function addSignal($signal, $listener)
174174
}
175175
}
176176

177-
public function removeSignal($signal, $listener)
177+
public function removeSignal(int $signal, callable $listener): void
178178
{
179179
$this->signals->remove($signal, $listener);
180180

@@ -184,7 +184,7 @@ public function removeSignal($signal, $listener)
184184
}
185185
}
186186

187-
public function run()
187+
public function run(): void
188188
{
189189
$this->running = true;
190190

@@ -202,7 +202,7 @@ public function run()
202202
}
203203
}
204204

205-
public function stop()
205+
public function stop(): void
206206
{
207207
$this->running = false;
208208
}

‎src/ExtUvLoop.php

+12-12
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public function getUvLoop()
5858
/**
5959
* {@inheritdoc}
6060
*/
61-
public function addReadStream($stream, $listener)
61+
public function addReadStream($stream, callable $listener): void
6262
{
6363
if (isset($this->readStreams[(int) $stream])) {
6464
return;
@@ -71,7 +71,7 @@ public function addReadStream($stream, $listener)
7171
/**
7272
* {@inheritdoc}
7373
*/
74-
public function addWriteStream($stream, $listener)
74+
public function addWriteStream($stream, callable $listener): void
7575
{
7676
if (isset($this->writeStreams[(int) $stream])) {
7777
return;
@@ -84,7 +84,7 @@ public function addWriteStream($stream, $listener)
8484
/**
8585
* {@inheritdoc}
8686
*/
87-
public function removeReadStream($stream)
87+
public function removeReadStream($stream): void
8888
{
8989
if (!isset($this->streamEvents[(int) $stream])) {
9090
return;
@@ -97,7 +97,7 @@ public function removeReadStream($stream)
9797
/**
9898
* {@inheritdoc}
9999
*/
100-
public function removeWriteStream($stream)
100+
public function removeWriteStream($stream): void
101101
{
102102
if (!isset($this->streamEvents[(int) $stream])) {
103103
return;
@@ -110,7 +110,7 @@ public function removeWriteStream($stream)
110110
/**
111111
* {@inheritdoc}
112112
*/
113-
public function addTimer($interval, $callback)
113+
public function addTimer($interval, callable $callback): TimerInterface
114114
{
115115
$timer = new Timer($interval, $callback, false);
116116

@@ -137,7 +137,7 @@ public function addTimer($interval, $callback)
137137
/**
138138
* {@inheritdoc}
139139
*/
140-
public function addPeriodicTimer($interval, $callback)
140+
public function addPeriodicTimer($interval, callable $callback): TimerInterface
141141
{
142142
$timer = new Timer($interval, $callback, true);
143143

@@ -161,7 +161,7 @@ public function addPeriodicTimer($interval, $callback)
161161
/**
162162
* {@inheritdoc}
163163
*/
164-
public function cancelTimer(TimerInterface $timer)
164+
public function cancelTimer(TimerInterface $timer): void
165165
{
166166
if (isset($this->timers[$timer])) {
167167
@\uv_timer_stop($this->timers[$timer]);
@@ -172,12 +172,12 @@ public function cancelTimer(TimerInterface $timer)
172172
/**
173173
* {@inheritdoc}
174174
*/
175-
public function futureTick($listener)
175+
public function futureTick(callable $listener): void
176176
{
177177
$this->futureTickQueue->add($listener);
178178
}
179179

180-
public function addSignal($signal, $listener)
180+
public function addSignal(int $signal, callable $listener): void
181181
{
182182
$this->signals->add($signal, $listener);
183183

@@ -189,7 +189,7 @@ public function addSignal($signal, $listener)
189189
}
190190
}
191191

192-
public function removeSignal($signal, $listener)
192+
public function removeSignal(int $signal, callable $listener): void
193193
{
194194
$this->signals->remove($signal, $listener);
195195

@@ -202,7 +202,7 @@ public function removeSignal($signal, $listener)
202202
/**
203203
* {@inheritdoc}
204204
*/
205-
public function run()
205+
public function run(): void
206206
{
207207
$this->running = true;
208208

@@ -233,7 +233,7 @@ public function run()
233233
/**
234234
* {@inheritdoc}
235235
*/
236-
public function stop()
236+
public function stop(): void
237237
{
238238
$this->running = false;
239239
}

0 commit comments

Comments
 (0)