Express 5 support in @react-router/express

[acelaya]

EDIT: Express 5 has been supported for some time already. You may need to do some changes in your code though, so:

1. Follow the migration guide, specially around optional path arguments: https://expressjs.com/en/guide/migrating-5.html
2. See @sanisoclem comment below: Express 5 support in `@react-router/express` #12717 (comment)

The package @react-router/express currently has a peer dependency on express: ^4.17.1. It would be great if support for express 5 was officially added.

[luisrudge]

error with express 5:

68 |             if (pos) {
69 |                 throw new TypeError(`Unterminated quote at ${pos}: ${DEBUG_URL}`);
70 |             }
71 |         }
72 |         if (!value) {
73 |             throw new TypeError(`Missing parameter name at ${i}: ${DEBUG_URL}`);
                       ^
TypeError: Missing parameter name at 1: https://git.new/pathToRegexpError
      at name (/project/node_modules/router/node_modules/path-to-regexp/dist/index.js:73:19)
      at lexer (/project/node_modules/router/node_modules/path-to-regexp/dist/index.js:91:27)
      at peek (/project/node_modules/router/node_modules/path-to-regexp/dist/index.js:106:38)
      at tryConsume (/project/node_modules/router/node_modules/path-to-regexp/dist/index.js:112:28)
      at text (/project/node_modules/router/node_modules/path-to-regexp/dist/index.js:128:30)
      at consume (/project/node_modules/router/node_modules/path-to-regexp/dist/index.js:152:29)
      at parse (/project/node_modules/router/node_modules/path-to-regexp/dist/index.js:183:20)
      at map (1:11)
      at pathToRegexp (/project/node_modules/router/node_modules/path-to-regexp/dist/index.js:294:25)
      at match (/project/node_modules/router/node_modules/path-to-regexp/dist/index.js:264:30)
      at new Layer (/project/node_modules/router/lib/layer.js:90:62)
      at route (/project/node_modules/router/index.js:421:17)
      at all (/project/node_modules/express/lib/application.js:497:20)
      at /project/server.ts:31:5

[sanisoclem]

splat syntax has changed in v5: https://expressjs.com/en/guide/migrating-5.html#path-syntax

change your app.all( '*', createRequestHandler(...)) to app.all( '*splat', createRequestHandler(...))

[acelaya]

Express 5 has been supported for some time and there's now a path to adopt it. Closing this.