Skip to content

Autofix detection and potential ghost crate issue in unlinked_file #19403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ljahier opened this issue Mar 20, 2025 · 0 comments
Open

Autofix detection and potential ghost crate issue in unlinked_file #19403

ljahier opened this issue Mar 20, 2025 · 0 comments
Labels
C-support Category: support questions

Comments

@ljahier
Copy link

ljahier commented Mar 20, 2025

Description:
While addressing a FIXME related to autofix detection in unlinked_file, I noticed that some files are incorrectly marked as unlinked due to what seems to be a ghost crate detection issue. This occurs when a file appears to belong to a crate but isn’t properly linked to a valid root (main.rs or lib.rs).

Key Observations:

  • is_in_crate = true, is_crate_root = false, but is_unlinked = false, yet autofix suggestions still appear.
  • Some files seem to be falsely classified as part of a crate even if they lack a proper root.
  • Modifying crate detection logic affects multiple tests, suggesting intentional behavior (e.g., for VS Code extension).

Current Status & Next Steps:

Logs & Test Output:
(See PR for details)

Would appreciate any insights on how best to resolve this while maintaining expected behavior. Thanks !

@ljahier ljahier added the C-support Category: support questions label Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-support Category: support questions
Projects
None yet
Development

No branches or pull requests

1 participant