Find out cause of DeprecatedAnnotationRemovalTaskTest, issue #15

Author: Sipkab

main/src/test/testing/saker/java/compiler/tests/tasks/javac/DeprecatedAnnotationRemovalTaskTest.java

@@ -7,6 +7,9 @@
 /**
  * It was encountered once that removing the @Deprecated annotation from an interface field did not remove the warning
  * from the source files in which it was used.
+ * <p>
+ * It is caused by the deprecated tag being present in the javadoc, but not on the field. Therefore as there is no ABI
+ * change, the dependent source files are not recompiled.
  */
 @SakerTest
 public class DeprecatedAnnotationRemovalTaskTest extends JavaCompilerVariablesMetricEnvironmentTaskTestCase {
@@ -19,12 +22,24 @@ protected void runNestTaskTestImpl() throws Throwable {
 		assertCompiled(MAIN_JAVA_PATH, ITF_JAVA_PATH);
 		assertTrue(getMetric().getAllPrintedTaskLines().contains(
 				"[saker.java.compile:src]src/test/Main.java:5:39-47: Warning: FIELD in test.Itf has been deprecated"));
+		assertTrue(getMetric().getAllPrintedTaskLines().contains(
+				"[saker.java.compile:src]src/test/Main.java:6:39-51: Warning: DOC_FIELD in test.Itf has been deprecated"));
 
-		//check if the warning was removed
 		files.putFile(ITF_JAVA_PATH, files.getAllBytes(ITF_JAVA_PATH).toString().replace("@Deprecated", ""));
 		runScriptTask("build");
 		assertCompiled(MAIN_JAVA_PATH, ITF_JAVA_PATH);
 		assertFalse(getMetric().getAllPrintedTaskLines().contains(
 				"[saker.java.compile:src]src/test/Main.java:5:39-47: Warning: FIELD in test.Itf has been deprecated"));
+		assertTrue(getMetric().getAllPrintedTaskLines().contains(
+				"[saker.java.compile:src]src/test/Main.java:6:39-51: Warning: DOC_FIELD in test.Itf has been deprecated"));
+
+		//TODO Fix this, issue #15 https://github.com/sakerbuild/saker.java.compiler/issues/15
+//		files.putFile(ITF_JAVA_PATH, files.getAllBytes(ITF_JAVA_PATH).toString().replace("@deprecated doc_dep", ""));
+//		runScriptTask("build");
+//		assertCompiled(MAIN_JAVA_PATH, ITF_JAVA_PATH);
+//		assertFalse(getMetric().getAllPrintedTaskLines().contains(
+//				"[saker.java.compile:src]src/test/Main.java:5:39-47: Warning: FIELD in test.Itf has been deprecated"));
+//		assertFalse(getMetric().getAllPrintedTaskLines().contains(
+//				"[saker.java.compile:src]src/test/Main.java:6:39-51: Warning: DOC_FIELD in test.Itf has been deprecated"));
 	}
 }

main/test/resources/testcontents/testing/saker/java/compiler/tests/tasks/javac/DeprecatedAnnotationRemovalTaskTest/src/test/Itf.java

@@ -1,6 +1,9 @@
 package test;
 
 public interface Itf {
-	@Deprecated
-	int FIELD = 0;
+	@Deprecated	int FIELD = 0;
+	/**
+	 * @deprecated doc_dep
+	 */
+	int DOC_FIELD = 1;
 }

main/test/resources/testcontents/testing/saker/java/compiler/tests/tasks/javac/DeprecatedAnnotationRemovalTaskTest/src/test/Main.java

@@ -3,5 +3,6 @@
 public class Main {
 	public static void main(String[] args) {
 		System.out.println("Main.main() " + Itf.FIELD);
+		System.out.println("Main.main() " + Itf.DOC_FIELD);
 	}
 }