Skip to content

Commit a41f30e

Browse files
committed
fix: correct FLOAT64_MAX_SAFE_NTH_FACTORIAL
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 0d53bc8 commit a41f30e

File tree

7 files changed

+13
-13
lines changed

7 files changed

+13
-13
lines changed

Diff for: lib/node_modules/@stdlib/constants/float64/max-safe-nth-factorial/README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ The maximum [safe][safe-integers] nth [factorial][factorial] when stored in [dou
3939
<!-- eslint-disable id-length -->
4040

4141
```javascript
42-
var bool = ( FLOAT64_MAX_SAFE_NTH_FACTORIAL === 170 );
42+
var bool = ( FLOAT64_MAX_SAFE_NTH_FACTORIAL === 18 );
4343
// returns true
4444
```
4545

@@ -69,7 +69,7 @@ function factorial( n ) {
6969
return a;
7070
}
7171

72-
for ( i = 0; i < 200; i++ ) {
72+
for ( i = 0; i < 50; i++ ) {
7373
v = factorial( i );
7474
if ( i > FLOAT64_MAX_SAFE_NTH_FACTORIAL ) {
7575
console.log( 'Unsafe: %d', v );

Diff for: lib/node_modules/@stdlib/constants/float64/max-safe-nth-factorial/docs/repl.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
Examples
77
--------
88
> {{alias}}
9-
170
9+
18
1010

1111
See Also
1212
--------

Diff for: lib/node_modules/@stdlib/constants/float64/max-safe-nth-factorial/docs/types/index.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
*
2424
* @example
2525
* var max = FLOAT64_MAX_SAFE_NTH_FACTORIAL;
26-
* // returns 170
26+
* // returns 18
2727
*/
2828
declare const FLOAT64_MAX_SAFE_NTH_FACTORIAL: number;
2929

Diff for: lib/node_modules/@stdlib/constants/float64/max-safe-nth-factorial/examples/index.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
'use strict';
2020

21-
var FLOAT64_MAX_SAFE_NTH_FACTORIAL = require( './../lib' );
21+
var FLOAT64_MAX_SAFE_NTH_FACTORIAL = require( './../lib' ); // eslint-disable-line id-length
2222

2323
var v;
2424
var i;
@@ -34,7 +34,7 @@ function factorial( n ) {
3434
return a;
3535
}
3636

37-
for ( i = 0; i < 200; i++ ) {
37+
for ( i = 0; i < 50; i++ ) {
3838
v = factorial( i );
3939
if ( i > FLOAT64_MAX_SAFE_NTH_FACTORIAL ) {
4040
console.log( 'Unsafe: %d', v );

Diff for: lib/node_modules/@stdlib/constants/float64/max-safe-nth-factorial/include/stdlib/constants/float64/max_safe_nth_factorial.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,6 @@
2222
/**
2323
* Macro for the maximum safe nth factorial when stored in double-precision floating-point format.
2424
*/
25-
#define STDLIB_CONSTANT_FLOAT64_MAX_SAFE_NTH_FACTORIAL 170
25+
#define STDLIB_CONSTANT_FLOAT64_MAX_SAFE_NTH_FACTORIAL 18
2626

2727
#endif // !STDLIB_CONSTANTS_FLOAT64_MAX_SAFE_NTH_FACTORIAL_H

Diff for: lib/node_modules/@stdlib/constants/float64/max-safe-nth-factorial/lib/index.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
*
2727
* @example
2828
* var FLOAT64_MAX_SAFE_NTH_FACTORIAL = require( '@stdlib/constants/float64/max-safe-nth-factorial' );
29-
* // returns 170
29+
* // returns 18
3030
*/
3131

3232

@@ -37,11 +37,11 @@
3737
*
3838
* @constant
3939
* @type {integer}
40-
* @default 170
40+
* @default 18
4141
* @see [factorial]{@link https://en.wikipedia.org/wiki/Factorial}
4242
* @see [IEEE 754]{@link https://en.wikipedia.org/wiki/IEEE_754-1985}
4343
*/
44-
var FLOAT64_MAX_SAFE_NTH_FACTORIAL = 170|0; // asm type annotation
44+
var FLOAT64_MAX_SAFE_NTH_FACTORIAL = 18|0; // asm type annotation
4545

4646

4747
// EXPORTS //

Diff for: lib/node_modules/@stdlib/constants/float64/max-safe-nth-factorial/test/test.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
// MODULES //
2222

2323
var tape = require( 'tape' );
24-
var FLOAT64_MAX_SAFE_NTH_FACTORIAL = require( './../lib' );
24+
var FLOAT64_MAX_SAFE_NTH_FACTORIAL = require( './../lib' ); // eslint-disable-line id-length
2525

2626

2727
// TESTS //
@@ -32,7 +32,7 @@ tape( 'main export is a number', function test( t ) {
3232
t.end();
3333
});
3434

35-
tape( 'the exported value is 170', function test( t ) {
36-
t.strictEqual( FLOAT64_MAX_SAFE_NTH_FACTORIAL, 170, 'returns expected value' );
35+
tape( 'the exported value is 18', function test( t ) {
36+
t.strictEqual( FLOAT64_MAX_SAFE_NTH_FACTORIAL, 18, 'returns expected value' );
3737
t.end();
3838
});

0 commit comments

Comments
 (0)