Skip to content

Commit 6bd6e7d

Browse files
authored
Merge pull request #90 from yzxiu/main
Fix the issue of being unable to read the PUSH_REVIEW_ENABLED environ…
2 parents 9dc615a + 4b5ff3a commit 6bd6e7d

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

Diff for: api.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424

2525

2626

27-
PUSH_REVIEW_ENABLED = os.environ.get('PUSH_REVIEW_ENABLED', '0') == '1'
27+
push_review_enabled = os.environ.get('PUSH_REVIEW_ENABLED', '0') == '1'
2828

2929

3030
@api_app.route('/')
@@ -43,7 +43,7 @@ def daily_report():
4343
end_time = datetime.now().replace(hour=23, minute=59, second=59, microsecond=0).timestamp()
4444

4545
try:
46-
if PUSH_REVIEW_ENABLED:
46+
if push_review_enabled:
4747
df = ReviewService().get_push_review_logs(updated_at_gte=start_time, updated_at_lte=end_time)
4848
else:
4949
df = ReviewService().get_mr_review_logs(updated_at_gte=start_time, updated_at_lte=end_time)

Diff for: biz/queue/worker.py

+4-3
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@
1010
from biz.utils.im import notifier
1111
from biz.utils.log import logger
1212

13-
PUSH_REVIEW_ENABLED = os.environ.get('PUSH_REVIEW_ENABLED', '0') == '1'
1413

1514

1615
def handle_push_event(webhook_data: dict, gitlab_token: str, gitlab_url: str, gitlab_url_slug: str):
16+
push_review_enabled = os.environ.get('PUSH_REVIEW_ENABLED', '0') == '1'
1717
try:
1818
handler = PushHandler(webhook_data, gitlab_token, gitlab_url)
1919
logger.info('Push Hook event received')
@@ -24,7 +24,7 @@ def handle_push_event(webhook_data: dict, gitlab_token: str, gitlab_url: str, gi
2424

2525
review_result = None
2626
score = 0
27-
if PUSH_REVIEW_ENABLED:
27+
if push_review_enabled:
2828
# 获取PUSH的changes
2929
changes = handler.get_push_changes()
3030
logger.info('changes: %s', changes)
@@ -119,6 +119,7 @@ def handle_merge_request_event(webhook_data: dict, gitlab_token: str, gitlab_url
119119
logger.error('出现未知错误: %s', error_message)
120120

121121
def handle_github_push_event(webhook_data: dict, github_token: str, github_url: str, github_url_slug: str):
122+
push_review_enabled = os.environ.get('PUSH_REVIEW_ENABLED', '0') == '1'
122123
try:
123124
handler = GithubPushHandler(webhook_data, github_token, github_url)
124125
logger.info('GitHub Push event received')
@@ -129,7 +130,7 @@ def handle_github_push_event(webhook_data: dict, github_token: str, github_url:
129130

130131
review_result = None
131132
score = 0
132-
if PUSH_REVIEW_ENABLED:
133+
if push_review_enabled:
133134
# 获取PUSH的changes
134135
changes = handler.get_push_changes()
135136
logger.info('changes: %s', changes)

0 commit comments

Comments
 (0)