Skip to content

Commit 7e1a61c

Browse files
Simon-He95johnsoncodehk
authored andcommitted
perf(extension): skip some extra condition (#3781)
1 parent d909b35 commit 7e1a61c

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

extensions/vscode/src/features/doctor.ts

+3-4
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@ export async function register(context: vscode.ExtensionContext, client: BaseLan
9494
message: string;
9595
}[] = [];
9696

97-
// check vue version < 2.7 but @vue/runtime-dom missing
9897
if (vueMod && semver.lt(vueMod.json.version, '2.7.0') && !domMod) {
98+
// check vue version < 2.7 but @vue/runtime-dom missing
9999
problems.push({
100100
title: '`@vue/runtime-dom` missing for Vue 2',
101101
message: [
@@ -105,9 +105,8 @@ export async function register(context: vscode.ExtensionContext, client: BaseLan
105105
].join('\n'),
106106
});
107107
}
108-
109-
// check vue version >= 2.7 and < 3 but installed @vue/runtime-dom
110-
if (vueMod && semver.gte(vueMod.json.version, '2.7.0') && semver.lt(vueMod.json.version, '3.0.0') && domMod) {
108+
else if (vueMod && semver.gte(vueMod.json.version, '2.7.0') && semver.lt(vueMod.json.version, '3.0.0') && domMod) {
109+
// check vue version >= 2.7 and < 3 but installed @vue/runtime-dom
111110
problems.push({
112111
title: 'Unnecessary `@vue/runtime-dom`',
113112
message: [

0 commit comments

Comments
 (0)