Skip to content

Commit e1fc38c

Browse files
[view-transitions] Fix incomplete pausing of animations in reftests
Several reftests were producing off by one errors in color matching. animation-play-state is not an inherited property from view-transition-group(*). Where the play-state was being explicitly paused for reftest matching, we need to explicitly pause on image-pair, image-old and image-new as well as the group. Flake easily reproducible with --repeat-each=10 without the patch. Not seeing flakes with --repeat-each=100 with the patch. Bug: 324915834 Change-Id: I76c86199f4d4734f0b2f1db0c79cdc962e2627ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6404354 Commit-Queue: Kevin Ellis <[email protected]> Reviewed-by: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1438949}
1 parent 8368838 commit e1fc38c

5 files changed

+20
-5
lines changed

Diff for: css/css-view-transitions/pseudo-with-classes-mismatch-ident.html

+4-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,10 @@
2020
view-transition-class: cls;
2121
}
2222

23-
::view-transition-group(*) {
23+
::view-transition-group(*),
24+
::view-transition-image-pair(*),
25+
::view-transition-old(*),
26+
::view-transition-new(*) {
2427
animation-play-state: paused;
2528
}
2629

Diff for: css/css-view-transitions/pseudo-with-classes-mismatch-partial.html

+4-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,10 @@
2020
view-transition-class: cls;
2121
}
2222

23-
::view-transition-group(*) {
23+
::view-transition-group(*),
24+
::view-transition-image-pair(*),
25+
::view-transition-old(*),
26+
::view-transition-new(*) {
2427
animation-play-state: paused;
2528
}
2629

Diff for: css/css-view-transitions/pseudo-with-classes-mismatch-wildcard.html

+4-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,10 @@
2020
view-transition-class: cls;
2121
}
2222

23-
::view-transition-group(*) {
23+
::view-transition-group(*),
24+
::view-transition-image-pair(*),
25+
::view-transition-old(*),
26+
::view-transition-new(*) {
2427
animation-play-state: paused;
2528
}
2629

Diff for: css/css-view-transitions/pseudo-with-classes-new-with-class-old-without.html

+4-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,10 @@
2323
view-transition-class: cls;
2424
}
2525

26-
::view-transition-group(*) {
26+
::view-transition-group(*),
27+
::view-transition-image-pair(*),
28+
::view-transition-old(*),
29+
::view-transition-new(*) {
2730
animation-play-state: paused;
2831
}
2932

Diff for: css/css-view-transitions/pseudo-with-classes-old-with-class-new-without.html

+4-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,10 @@
2323
view-transition-class: cls;
2424
}
2525

26-
::view-transition-group(*) {
26+
::view-transition-group(*),
27+
::view-transition-image-pair(*),
28+
::view-transition-old(*),
29+
::view-transition-new(*) {
2730
animation-play-state: paused;
2831
}
2932

0 commit comments

Comments
 (0)