chore: upgrade to golangci-lint v2 (#496)

* chore: upgrade to golangci-lint v2

* chore: golangci/[email protected]

Author: x1unix

Diff for: .github/workflows/pull_request.yml

@@ -44,8 +44,8 @@ jobs:
           go-version: "^1.24.0"
           cache-dependency-path: go.sum
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v6.5.2
+        uses: golangci/golangci-lint-action@v7.0.0
         with:
-          version: v1.64.6
+          version: v2.0.2
       - run: go version
       - run: go test ./...

Diff for: .golangci.yml

@@ -1,8 +1,20 @@
+version: "2"
 run:
   tests: false
-issues:
-  exclude-dirs:
-    - pkg/worker
-    - cmd/webworker
-    - web
-    - web/public/examples
+formatters:
+  exclusions:
+    paths:
+      - "pkg/worker/"
+      - "cmd/webworker/"
+      - "web/"
+
+linters:
+  exclusions:
+    rules:
+      - text: ".Close` is not checked"
+        linters:
+          - errcheck
+    paths:
+      - "pkg/worker/"
+      - "cmd/webworker/"
+      - "web/"

Diff for: internal/builder/runner.go

@@ -13,7 +13,7 @@ type CommandRunner interface {
 
 type OSCommandRunner struct{}
 
-func (_ OSCommandRunner) RunCommand(cmd *exec.Cmd) error {
+func (OSCommandRunner) RunCommand(cmd *exec.Cmd) error {
 	if err := cmd.Start(); err != nil {
 		return err
 	}

Diff for: internal/pkgindex/docutil/comments.go

@@ -130,7 +130,8 @@ func isDirective(c string) bool {
 			continue
 		}
 		b := c[i]
-		if !('a' <= b && b <= 'z' || '0' <= b && b <= '9') {
+		ok := 'a' <= b && b <= 'z' || '0' <= b && b <= '9'
+		if !ok {
 			return false
 		}
 	}

Diff for: internal/pkgindex/docutil/filter.go

@@ -29,7 +29,7 @@ func NewIgnoreList(names ...string) Filter {
 // UnexportedFilter filters private symbols
 type UnexportedFilter struct{}
 
-func (_ UnexportedFilter) Ignore(typeName string) bool {
+func (UnexportedFilter) Ignore(typeName string) bool {
 	return !token.IsExported(typeName)
 }
 

Diff for: internal/server/models.go

@@ -23,7 +23,7 @@ const (
 
 type deprecatedMessage struct{}
 
-func (_ deprecatedMessage) MarshalJSON() ([]byte, error) {
+func (deprecatedMessage) MarshalJSON() ([]byte, error) {
 	return []byte(deprecationMsg), nil
 }
 

Diff for: internal/server/response.go

@@ -30,14 +30,12 @@ func (p FilesPayload) Validate() error {
 	for name, src := range p.Files {
 		switch filepath.Ext(name) {
 		case ".go", ".mod":
-			break
+			if len(strings.TrimSpace(src)) == 0 {
+				return fmt.Errorf("empty file %q", name)
+			}
 		default:
 			return fmt.Errorf("invalid file type: %q", name)
 		}
-
-		if len(strings.TrimSpace(src)) == 0 {
-			return fmt.Errorf("empty file %q", name)
-		}
 	}
 
 	return nil

Diff for: internal/server/utils.go

@@ -31,7 +31,7 @@ func evalPayloadFromRequest(r *http.Request) ([]byte, error) {
 	// See: https://github.com/golang/go/issues/68327
 	if body.HasUnitTests() {
 		return nil, errors.New(
-			"Due to Go Playground bug, unit test snippets can't have multiple files.\n" +
+			"due to Go Playground bug, unit test snippets can't have multiple files.\n" +
 				"Please remove other Go files or use WebAssembly environment instead.\n\n" +
 				"See: https://github.com/golang/go/issues/32403",
 		)

Diff for: internal/util/buffutil/bufferpool.go

@@ -43,7 +43,7 @@ func (p *BufferPool) Put(b RecyclableBuffer) {
 		panic("BufferPool.Put: RecyclableBuffer was already recycled")
 	}
 
-	b.Buffer.Reset()
+	b.Reset()
 	p.pool.Put(b.Buffer)
 	b.pool = nil
 	b.Buffer = nil