Add CI build against deps located on the system #1865
Conversation
If the user explicitely requests to use find_package to use the system Imath it seems wrong to fallback to the delivered Imath Signed-off-by: Julius Künzel <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes. Additional details and impacted files@@ Coverage Diff @@
## main #1865 +/- ##
==========================================
+ Coverage 84.11% 84.72% +0.61%
==========================================
Files 198 177 -21
Lines 22241 12809 -9432
Branches 4687 1191 -3496
==========================================
- Hits 18709 10853 -7856
+ Misses 2610 1773 -837
+ Partials 922 183 -739
Flags with carried forward coverage won't be shown. Click here to find out more. see 131 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
jlskuz
force-pushed
the
work/deps-ci
branch
2 times, most recently
from
faff9b0 to
fceb2af
Compare
Signed-off-by: Julius Künzel <[email protected]>
| if: matrix.os == env.GH_COV_OS && github.actor != env.GH_DEPENDABOT | ||
| run: | | ||
| cd ${{ env.OTIO_BUILD_DIR }} | ||
| lcov --rc lcov_branch_coverage=1 --rc no_exception_branch=1 --ignore-errors mismatch --capture -b . --directory . --output-file=coverage.info -q | ||
| cat coverage.info | sed "s/SF:.*src/SF:src/g" > coverage.filtered.info | ||
| lcov --remove coverage.filtered.info '*/tests/*' --output-file=coverage.filtered.info -q | ||
| lcov --list coverage.filtered.info |
There was a problem hiding this comment.
I don't think you need to run the coverage step, since that is covered by the generic test
| @@ -88,6 +88,63 @@ jobs: | |||
| cd ${{ env.OTIO_CONSUMER_TEST_BUILD_DIR }} | |||
| cmake ${{ github.workspace }}/tests/consumer -DCMAKE_PREFIX_PATH=${{ env.OTIO_INSTALL_DIR }} | |||
|
|
|||
| cpp_build_external_deps: | |||
There was a problem hiding this comment.
A comment describing this job and what distinguishes this from the simple cpp_build job would be nice.
With three jobs, it feels like we would want comments on the other two as well, but that is outside the scope of thisPR.
Add a CI build to test with
OTIO_FIND_RAPIDJSON=ONandOTIO_FIND_IMATH=ON