-
Notifications
You must be signed in to change notification settings - Fork 24
Add eslint linting #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add eslint linting #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-ostapenko
approved these changes
Mar 5, 2025
Co-authored-by: Max Ostapenko <[email protected]>
https://almanac.httparchive.org/en/2022/Cannot display changed custom metrics due to comment size limits, view test JSON instead. https://example.comChanged custom metrics values: {
"_Images": [],
"_a11y": {
"tables": {
"total": 0,
"total_with_caption": 0,
"total_with_presentational": 0,
"total_with_figcaption": 0
},
"file_extension_alts": {
"total_elements_with_alt": 0,
"total_elements_with_non_empty_alt": 0,
"total_with_file_extension": 0,
"file_extensions": {}
},
"title_and_alt": {
"total_alt": 0,
"total_title": 0,
"total_both": 0,
"total_alt_same_as_title": 0
},
"th_with_scope_attribute": {
"total_th": 0,
"total_with_scope": 0,
"scopes": {}
},
"td_with_headers_attribute": {
"total_tds": 0,
"total_with_headers": 0
},
"total_anchors_with_role_button": 0,
"total_role_tab_with_selected_and_controls": 0,
"placeholder_but_no_label": {
"total_placeholder": 0,
"total_no_label": 0
},
"divs_or_spans_as_button_or_link": {
"total_role_button": 0,
"total_role_link": 0,
"total_either": 0
},
"screen_reader_classes": false,
"form_control_a11y_tree": [],
"fieldset_radio_checkbox": {
"total_radio": 0,
"total_checkbox": 0,
"total_radio_in_fieldset": 0,
"total_checkbox_in_fieldset": 0,
"fieldsets": []
},
"required_form_controls": []
},
"_ads": {
"ads": {
"status": -1,
"present": false,
"error": "signal is aborted without reason"
},
"app_ads": {
"status": -1,
"present": false,
"error": "signal is aborted without reason"
},
"sellers": {
"status": -1,
"present": false,
"error": "signal is aborted without reason"
}
},
"_almanac": {
"01.12": 0,
"01.13": 0,
"link-nodes": {
"total": 0,
"nodes": [],
"attribute_usage_count": {}
},
"priority-hints": {
"total": 0,
"nodes": [],
"attribute_usage_count": {}
},
"meta-nodes": {
"total": 3,
"nodes": [
{
"tagName": "meta",
"charset": "utf-8"
},
{
"tagName": "meta",
"http-equiv": "Content-type",
"content": "text/html; charset=utf-8"
},
{
"tagName": "meta",
"name": "viewport",
"content": "width=device-width, initial-scale=1"
}
],
"attribute_usage_count": {
"charset": 1,
"http-equiv": 1,
"content": 2,
"name": 1
}
},
"10.5": [],
"seo-anchor-elements": {
"internal": 0,
"external": 1,
"hash": 0,
"navigateHash": 0,
"earlyHash": 0
},
"seo-titles": {
"titleWords": 2,
"titleElements": 1
},
"seo-words": {
"wordsCount": 24,
"wordElements": 1
},
"input_elements": {
"total": 0,
"nodes": [],
"attribute_usage_count": {}
},
"link_protocols_used": {
"https": 1
},
"06.47": 0,
"08.39": {
"link": 0,
"script": 0
},
"09.27": {
"total": 0,
"nodes": [],
"attribute_usage_count": {}
},
"icon_only_clickables": 0,
"inline_svg_stats": {
"total": 0,
"content_lengths": [],
"attribute_usage_count": {}
},
"images": {
"pictures": {
"total": 0,
"nodes": [],
"attribute_usage_count": {}
},
"imgs": {
"total": 0,
"nodes": [],
"attribute_usage_count": {}
},
"sources": {
"total": 0,
"nodes": [],
"attribute_usage_count": {}
},
"total_with_srcset": 0,
"total_with_sizes": 0,
"total_pictures_with_img": 0,
"sizes_values": [],
"loading_values": [],
"alt_lengths": []
},
"videos": {
"total": 0,
"nodes": [],
"attribute_usage_count": {},
"total_with_track": 0,
"tracks": {
"total": 0,
"nodes": [],
"attribute_usage_count": {}
}
},
"audios": {
"total": 0,
"nodes": [],
"attribute_usage_count": {},
"total_with_track": 0,
"tracks": {
"total": 0,
"nodes": [],
"attribute_usage_count": {}
}
},
"iframes": {
"iframes": {
"total": 0,
"nodes": [],
"attribute_usage_count": {}
},
"loading_values": []
},
"scripts": {
"total": 0,
"nodes": [],
"attribute_usage_count": {}
},
"nodes_using_role": {
"total": 0,
"usage_and_count": {}
},
"headings_order": [
1
],
"shortcuts_stats": {
"total_with_aria_shortcut": 0,
"total_with_accesskey": 0,
"aria_shortcut_values": [],
"accesskey_values": []
},
"attributes_used_on_elements": {
"charset": 1,
"http-equiv": 1,
"content": 2,
"name": 1,
"type": 1,
"href": 1
},
"body_node": {
"tagName": "body"
},
"html_node": {
"tagName": "html"
},
"document_title": {
"value": "Example Domain",
"length": 14
},
"length_of_h1s": [
14
]
},
"_avg_dom_depth": 3,
"_cms": {
"wordpress": {
"theme": {
"theme": null,
"child_theme": null
},
"block_theme": false,
"has_embed_block": false,
"embed_block_count": {
"total": 0,
"total_by_type": []
},
"scripts": [],
"content_type": {
"template": "unknown",
"post_type": "",
"taxonomy": ""
},
"uses_interactivity_api": false,
"interactivity_api_usage": {
"total_regions": 0,
"total_regions_by_namespace": []
}
}
},
"_crawl_links": [],
"_css": {
"css_in_js": [],
"prefersColorScheme": false,
"externalCssInHead": 0,
"externalCssInBody": 0,
"inlineCssInHead": 1,
"inlineCssInBody": 0
},
"_css-variables": {
"summary": {}
},
"_doctype": "html",
"_event-names": [],
"_fugu-apis": [],
"_javascript": {
"ajax_requests": {
"xmlhttprequest": 0,
"fetch": 5,
"beacon": 0,
"total": 5
},
"beacon_ajax_usage": 0,
"iframe": 0,
"requests_protocol": {
"ajax_h1": 0,
"resources_h1": 0,
"ajax_h2": 0,
"resources_h2": 1,
"ajax_h3": 0,
"resources_h3": 0
},
"web_component_specs": {
"custom_elements": [],
"shadow_roots": [],
"template": []
},
"script_tags": {
"total": 0,
"async": 0,
"defer": 0,
"crossorigin": 0,
"integrity": 0,
"nomodule": 0,
"nonce": 0,
"referrerpolicy": 0,
"src": 0,
"inline": 0,
"type_module": 0,
"async_and_defer": 0,
"defer_without_src": 0,
"charset": 0,
"language": 0
},
"noscript_tags": {
"total": 0
},
"sourceMaps": {
"count": 0,
"ext": {}
},
"bundler": [],
"document": {
"length": 1256,
"elements": 12,
"links": 0,
"stylesheets": 0,
"inlineStyles": 1,
"scripts": 0,
"inlineScripts": 0
}
},
"_localstorage_size": 0,
"_markup": {
"favicon": false,
"rel_alternate_mobile": false,
"compatMode": "CSS1Compat",
"noscripts": {
"iframe_googletagmanager_count": 0,
"total": 0
},
"buttons": {
"types": {},
"total": 0
},
"form": {
"target": {},
"method": {},
"elements": [],
"total": 0
},
"dirs": {
"html_dir": null,
"body_nodes_dir": {
"values": {},
"total": 0
}
},
"inputs": {
"types": {},
"total": 0
},
"audios": {
"autoplay": {},
"total": 0
},
"classes": {
"unique_names_total": 0,
"references_total": 0
},
"ids": {
"ids_total": 0,
"duplicate_ids_total": 0,
"unique_ids_total": 0
},
"images": {
"picture": {
"total": 0
},
"source": {
"total": 0,
"src_total": 0,
"srcset_total": 0,
"media_total": 0,
"type_total": 0
},
"img": {
"total": 0,
"src_total": 0,
"srcset_total": 0,
"alt": {
"missing": 0,
"blank": 0,
"present": 0
},
"loading": {
"auto": 0,
"lazy": 0,
"eager": 0,
"invalid": 0,
"missing": 0,
"blank": 0
},
"dimensions": {
"missing_width": 0,
"missing_height": 0
}
}
},
"iframes": {
"total": 0,
"loading": {
"auto": 0,
"lazy": 0,
"eager": 0,
"invalid": 0,
"missing": 0,
"blank": 0
}
},
"amp": {
"html_amp_attribute_present": false,
"html_amp_emoji_attribute_present": false,
"amp_page": false,
"rel_amphtml": null
},
"data_nosnippet": {
"valid": 0,
"wrong_tag_type": 0
},
"obsolete_elements": {},
"svgs": {
"svg_element_total": 0,
"svg_img_total": 0,
"svg_object_total": 0,
"svg_embed_total": 0,
"svg_iframe_total": 0,
"svg_total": 0
},
"app": {
"app_id_present": false,
"meta_theme_color": null
},
"anchors": {
"hrefs_without_special_scheme": []
},
"dom-shape": {
"bodyNodesCount": 5,
"bodyLeafNodesCount": 3,
"depth": {
"mean": 2.3333333333333335,
"median": 2,
"mode": 2,
"stddev": 0.4714045207910317,
"skew": 0.7071067811865478,
"range": {
"min": 2,
"max": 3
}
},
"bodyNonLeafNodesCount": 2,
"branchFactor": {
"mean": 4,
"median": 4,
"mode": 1,
"stddev": 3,
"skew": 1,
"range": {
"min": 1,
"max": 7
}
},
"branchFactorByDepth": [
{
"depth": 0,
"count": 1,
"mean": 3,
"stddev": 0,
"skew": null,
"median": 3,
"mode": 3,
"range": {
"min": 3,
"max": 3
}
},
{
"depth": 1,
"count": 1,
"mean": 7,
"stddev": 0,
"skew": null,
"median": 7,
"mode": 7,
"range": {
"min": 7,
"max": 7
}
},
{
"depth": 2,
"count": 1,
"mean": 1,
"stddev": 0,
"skew": null,
"median": 1,
"mode": 1,
"range": {
"min": 1,
"max": 1
}
}
]
}
},
"_media": {
"num_picture_img": 0,
"num_image_sizes": 0,
"num_srcset_all": 0,
"num_srcset_sizes": 0,
"num_srcset_descriptor_x": 0,
"num_srcset_descriptor_w": 0,
"num_srcset_candidates": 0,
"picture_formats": [],
"num_video_nodes": 0,
"video_durations": [],
"video_attributes_values_counts": [],
"video_display_style": [],
"video_using_source_media_count": 0,
"video_source_media_values": [],
"video_source_format_count": [],
"video_source_format_type": [],
"num_picture_using_min_resolution": 0,
"num_picture_using_orientation": 0,
"num_img_not_in_picture_srcset_candidates": 0
},
"_meta_viewport": "width=device-width, initial-scale=1",
"_num_scripts_async": 0,
"_num_scripts_sync": 0,
"_origin-trials": [],
"_parsed_css": [
{
"url": "block",
"ast": {
"type": "stylesheet",
"stylesheet": {
"rules": [
{
"type": "rule",
"selectors": [
"body"
],
"declarations": [
{
"type": "declaration",
"property": "background-color",
"value": "#f0f0f2"
},
{
"type": "declaration",
"property": "margin",
"value": "0"
},
{
"type": "declaration",
"property": "padding",
"value": "0"
},
{
"type": "declaration",
"property": "font-family",
"value": "-apple-system, system-ui, BlinkMacSystemFont, \"Segoe UI\", \"Open Sans\", \"Helvetica Neue\", Helvetica, Arial, sans-serif"
}
]
},
{
"type": "rule",
"selectors": [
"div"
],
"declarations": [
{
"type": "declaration",
"property": "width",
"value": "600px"
},
{
"type": "declaration",
"property": "margin",
"value": "5em auto"
},
{
"type": "declaration",
"property": "padding",
"value": "2em"
},
{
"type": "declaration",
"property": "background-color",
"value": "#fdfdff"
},
{
"type": "declaration",
"property": "border-radius",
"value": "0.5em"
},
{
"type": "declaration",
"property": "box-shadow",
"value": "2px 3px 7px 2px rgba(0,0,0,0.02)"
}
]
},
{
"type": "rule",
"selectors": [
"a:link",
"a:visited"
],
"declarations": [
{
"type": "declaration",
"property": "color",
"value": "#38488f"
},
{
"type": "declaration",
"property": "text-decoration",
"value": "none"
}
]
},
{
"type": "media",
"media": "(max-width: 700px)",
"rules": [
{
"type": "rule",
"selectors": [
"div"
],
"declarations": [
{
"type": "declaration",
"property": "margin",
"value": "0 auto"
},
{
"type": "declaration",
"property": "width",
"value": "auto"
}
]
}
]
}
],
"parsingErrors": []
}
}
}
],
"_performance": {
"lcp_elem_stats": {
"startTime": 420,
"nodeName": "P",
"url": "",
"size": 33858,
"loadTime": 0,
"renderTime": 420,
"attributes": [],
"boundingClientRect": {
"x": 383,
"y": 192.875,
"width": 600,
"height": 57,
"top": 192.875,
"right": 983,
"bottom": 249.875,
"left": 383
},
"styles": {
"background-image": "none",
"pointer-events": "auto",
"position": "static",
"width": "600px",
"height": "57px"
},
"percentOfViewport": "0.0368",
"cover90viewport": false
},
"raw_lcp_element": null,
"lcp_resource": null,
"is_lcp_statically_discoverable": true,
"is_lcp_preloaded": null,
"lcp_preload": null,
"web_vitals_js": [],
"gaming_metrics": [],
"speculation_rules": []
},
"_privacy": {
"privacy_wording_links": [],
"iab_tcf_v1": {
"present": false
},
"iab_tcf_v2": {
"present": false
},
"iab_gpp": {
"present": false
},
"iab_usp": {
"present": false
},
"navigator_doNotTrack": false,
"navigator_globalPrivacyControl": false,
"document_permissionsPolicy": false,
"document_featurePolicy": false,
"referrerPolicy": {
"entire_document_policy": null,
"individual_requests": null,
"link_relations": null
},
"media_devices": {
"navigator_mediaDevices_enumerateDevices": false,
"navigator_mediaDevices_getUserMedia": false,
"navigator_mediaDevices_getDisplayMedia": false
},
"geolocation": {
"navigator_geolocation_getCurrentPosition": false,
"navigator_geolocation_watchPosition": false
},
"fingerprinting": {
"counts": {},
"likelyFingerprintingScripts": []
},
"request_hostnames_with_cname": {},
"ccpa_link": {
"hasCCPALink": false
},
"iab_ddr": {
"status": -1,
"present": false,
"error": "signal is aborted without reason"
}
},
"_pwa": {
"serviceWorkers": [],
"manifests": [],
"serviceWorkerInitiated": [],
"workboxInfo": [],
"importScriptsInfo": [],
"swEventListenersInfo": [],
"swPropertiesInfo": [],
"swMethodsInfo": [],
"swObjectsInfo": [],
"swRegistrationPropertiesInfo": [],
"windowEventListenersInfo": [],
"windowPropertiesInfo": [],
"serviceWorkerRegistrationInfo": [],
"serviceWorkerHeuristic": false
},
"_responsive_images": {
"responsive-images": []
},
"_robots_meta": {
"main_frame_robots_rendered": [],
"main_frame_robots_raw": [],
"main_frame_robots_headers": [],
"iframe_robots_raw": [],
"iframe_robots_headers": [],
"main_frame_crawl_data": {
"rendered": [],
"raw": [],
"headers": [],
"all": []
}
},
"_robots_txt": {
"message": "signal is aborted without reason",
"error": {}
},
"_sessionstorage_size": 0,
"_test_result": 0,
"_valid-head": {
"invalidElements": [],
"invalidHead": false
},
"_wpt_bodies": {
"anchors": {
"rendered": {
"crawlable": {
"follow": 1,
"nofollow": 0
},
"hash_link": 0,
"hash_only_link": 0,
"javascript_void_links": 0,
"same_page": {
"total": 0,
"jumpto": {
"total": 0,
"early": 0,
"other": 0,
"using_id": 0,
"using_name": 0
},
"dynamic": {
"total": 0,
"onclick_attributes": {
"total": 0,
"window_location": 0,
"window_open": 0,
"unknown_action": 0
},
"href_javascript": 0,
"hash_link": 0
},
"other": {
"total": 0,
"hash_link": 0
}
},
"same_site": 0,
"same_property": 0,
"other_property": 1,
"rel_attributes": {
"dofollow": 0,
"follow": 0,
"nofollow": 0,
"ugc": 0,
"sponsored": 0,
"noopener": 0,
"noreferrer": 0
},
"image_links": 0,
"invisible_links": 0,
"text_links": 1,
"target_blank": {
"total": 0,
"noopener_noreferrer": 0,
"noopener": 0,
"noreferrer": 0,
"neither": 0
},
"targets": {},
"protocols": {
"https": 1
}
},
"raw": {
"crawlable": {
"follow": 1,
"nofollow": 0
},
"hash_link": 0,
"hash_only_link": 0,
"javascript_void_links": 0,
"same_page": {
"total": 0,
"jumpto": {
"total": 0,
"early": 0,
"other": 0,
"using_id": 0,
"using_name": 0
},
"dynamic": {
"total": 0,
"onclick_attributes": {
"total": 0,
"window_location": 0,
"window_open": 0,
"unknown_action": 0
},
"href_javascript": 0,
"hash_link": 0
},
"other": {
"total": 0,
"hash_link": 0
}
},
"same_site": 0,
"same_property": 0,
"other_property": 1,
"rel_attributes": {
"dofollow": 0,
"follow": 0,
"nofollow": 0,
"ugc": 0,
"sponsored": 0,
"noopener": 0,
"noreferrer": 0
},
"image_links": 0,
"invisible_links": 0,
"text_links": 1,
"target_blank": {
"total": 0,
"noopener_noreferrer": 0,
"noopener": 0,
"noreferrer": 0,
"neither": 0
},
"targets": {},
"protocols": {
"https": 1
}
}
},
"title": {
"rendered": {
"primary": {
"characters": 14,
"words": 2,
"text": "Example Domain"
},
"total": 1
},
"raw": {
"primary": {
"characters": 14,
"words": 2,
"text": "Example Domain"
},
"total": 1
},
"title_changed_on_render": false
},
"meta_description": {
"rendered": {
"all": {
"text": "",
"words": 0,
"characters": 0
},
"total": 0
},
"raw": {
"all": {
"text": "",
"words": 0,
"characters": 0
},
"total": 0
}
},
"hreflangs": {
"http_header": {
"values": []
},
"rendered": {
"values": []
},
"raw": {
"values": []
}
},
"headings": {
"rendered": {
"first_non_empty_heading_hidden": false,
"primary": {
"words": 2,
"characters": 14,
"matches_title": true,
"text": "Example Domain",
"level": 1
},
"h1": {
"total": 1,
"non_empty_total": 1,
"characters": 14,
"words": 2
},
"h2": {
"total": 0,
"non_empty_total": 0,
"characters": 0,
"words": 0
},
"h3": {
"total": 0,
"non_empty_total": 0,
"characters": 0,
"words": 0
},
"h4": {
"total": 0,
"non_empty_total": 0,
"characters": 0,
"words": 0
},
"h5": {
"total": 0,
"non_empty_total": 0,
"characters": 0,
"words": 0
},
"h6": {
"total": 0,
"non_empty_total": 0,
"characters": 0,
"words": 0
},
"h7": {
"total": 0,
"non_empty_total": 0,
"characters": 0,
"words": 0
},
"h8": {
"total": 0,
"non_empty_total": 0,
"characters": 0,
"words": 0
}
},
"raw": {
"first_non_empty_heading_hidden": false,
"primary": {
"words": 2,
"characters": 14,
"matches_title": true,
"text": "Example Domain",
"level": 1
},
"h1": {
"total": 1,
"non_empty_total": 1,
"characters": 14,
"words": 2
},
"h2": {
"total": 0,
"non_empty_total": 0,
"characters": 0,
"words": 0
},
"h3": {
"total": 0,
"non_empty_total": 0,
"characters": 0,
"words": 0
},
"h4": {
"total": 0,
"non_empty_total": 0,
"characters": 0,
"words": 0
},
"h5": {
"total": 0,
"non_empty_total": 0,
"characters": 0,
"words": 0
},
"h6": {
"total": 0,
"non_empty_total": 0,
"characters": 0,
"words": 0
},
"h7": {
"total": 0,
"non_empty_total": 0,
"characters": 0,
"words": 0
},
"h8": {
"total": 0,
"non_empty_total": 0,
"characters": 0,
"words": 0
}
}
},
"structured_data": {
"rendered": {
"jsonld_and_microdata_types": [],
"jsonldIds": 0,
"jsonldReferencedIds": 0,
"microdataIds": 0,
"microdataReferencedIds": 0,
"jsonlsMicrodataCommonIds": 0,
"logo": false,
"sitelinks_search_box": false,
"same_as_values": [],
"items_by_format": {
"microformats2": 0,
"microdata": 0,
"jsonld": 0,
"rdfa": 0
},
"context_hostnames": [],
"jsonld_scripts": {
"count": 0,
"errors": 0
},
"microformats2_types": []
},
"raw": {
"jsonld_and_microdata_types": [],
"jsonldIds": 0,
"jsonldReferencedIds": 0,
"microdataIds": 0,
"microdataReferencedIds": 0,
"jsonlsMicrodataCommonIds": 0,
"logo": false,
"sitelinks_search_box": false,
"same_as_values": [],
"items_by_format": {
"microformats2": 0,
"microdata": 0,
"jsonld": 0,
"rdfa": 0
},
"context_hostnames": [],
"jsonld_scripts": {
"count": 0,
"errors": 0
},
"microformats2_types": []
}
},
"raw_html": {
"body": true,
"html": true,
"head": true,
"size": 1256,
"head_size": 917,
"body_size": 305
},
"canonicals": {
"rendered": {
"html_link_canoncials": []
},
"raw": {
"html_link_canoncials": []
},
"self_canonical": false,
"other_canonical": false,
"canonicals": [],
"url": "https://example.com/",
"http_header_link_canoncials": [],
"canonical_missmatch": false
},
"robots": {
"has_robots_meta_tag": false,
"has_x_robots_tag": false,
"rendered": {
"otherbot": {
"status_index": true,
"status_follow": true,
"via_meta_tag": false,
"via_x_robots_tag": false
},
"googlebot": {
"status_index": true,
"status_follow": true,
"via_meta_tag": false,
"via_x_robots_tag": false
},
"googlebot_news": {
"status_index": true,
"status_follow": true,
"via_meta_tag": false,
"via_x_robots_tag": false
},
"google": {}
},
"raw": {
"otherbot": {
"status_index": true,
"status_follow": true,
"via_meta_tag": false,
"via_x_robots_tag": false
},
"googlebot": {
"status_index": true,
"status_follow": true,
"via_meta_tag": false,
"via_x_robots_tag": false
},
"googlebot_news": {
"status_index": true,
"status_follow": true,
"via_meta_tag": false,
"via_x_robots_tag": false
},
"google": {}
}
},
"visible_words": {
"rendered": 28,
"raw": 28
},
"web_components": {
"rendered": {
"customElements": {
"names": [],
"shadowRoots": [],
"templates": [],
"slots": []
},
"hyphenatedElements": {
"names": [],
"shadowRoots": [],
"templates": [],
"slots": []
}
},
"raw": {
"customElements": {
"names": [],
"shadowRoots": [],
"templates": [],
"slots": []
},
"hyphenatedElements": {
"names": [],
"shadowRoots": [],
"templates": [],
"slots": []
}
}
}
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this recently got enabled, but a lot of our custom metrics fail. And often for very good reasons.
Fixed them all up and think they look OK now, but there's a lot of change here so one to keep an eye on in next crawl.
Test websites: