remove redundant nullable #4608
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanOssendorf
previously approved these changes
Mar 23, 2025
|
Ah please solve the conflict. Thanks |
| @@ -136,7 +136,7 @@ protected virtual void OnGetChildren(SerializationInfo info, MobileFormatter for | |||
| List<int> references = new List<int>(); | |||
| for (int x = 0; x < Count; x++) | |||
| { | |||
| T? child = this[x]; | |||
| T child = this[x]; | |||
There was a problem hiding this comment.
Shouldnt this still be T?` because of the next line? Otherwise the check could be removed due to the missing annotation?
There was a problem hiding this comment.
no because MobileObservableCollection<T> has no notnull constraint.
There was a problem hiding this comment.
But exactly because of that we have to assume it can be nullable.
So T? child is more correct than T. With T we don't express the possibility of the child being null so the compiler can help us avoiding possible null errors?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.