Fix NULL pointer dereference vulnerability in cJSON_InsertItemInArray (CVE-2023-50471) #21086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please update the samples (pr checklist step 3) cc @zhemant (2018/11) @ityuhui (2019/12) @michelealbano (2020/03) @eafer (2024/12) |
|
I think we should probably update cJSON as a whole. There was some discussion of this matter before: #20431. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds NULL checks for the array and newitem parameters in the cJSON_InsertItemInArray function to prevent NULL pointer dereferences. This addresses the same vulnerability as CVE-2023-50471 which was fixed in the original cJSON repository.
References:
Original fix: DaveGamble/cJSON@60ff122
CVE-2023-50471: https://nvd.nist.gov/vuln/detail/CVE-2023-50471