Skip to content

[bazel] Bump to Bazel 8 #15512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: trunk
Choose a base branch
from
Open

[bazel] Bump to Bazel 8 #15512

wants to merge 9 commits into from

Conversation

shs96c
Copy link
Member

@shs96c shs96c commented Mar 26, 2025

PR Type

Enhancement, Configuration changes


Description

  • Updated Bazel version to 8.1.1 in .bazelversion.

  • Adjusted .bazelrc configurations for compatibility with Bazel 8.

  • Updated dependencies in MODULE.bazel to newer versions.


Changes walkthrough 📝

Relevant files
Configuration changes
.bazelrc
Update `.bazelrc` for Bazel 8 compatibility                           

.bazelrc

  • Removed deprecated Bazel 7 configurations.
  • Added new configurations for Bazel 8 compatibility.
  • Updated C++ standard to C++17.
  • Adjusted symlink and workspace-related settings.
  • +6/-9     
    .bazelversion
    Bump Bazel version to 8.1.1                                                           

    .bazelversion

    • Updated Bazel version from 7.4.1 to 8.1.1.
    +1/-1     
    Enhancement
    MODULE.bazel
    Update `rules_jvm_external` dependency version                     

    MODULE.bazel

    • Updated rules_jvm_external dependency to version 6.7.
    +1/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Version Conflict

    The file contains both the new version 8.1.1 and the old version 7.4.1 on separate lines. Only the new version should be present, but the old version wasn't properly removed.

    8.1.1
    Missing Configuration

    The lockfile mode configuration was removed (--lockfile_mode=off) but no replacement was added. This might affect module dependency resolution behavior in Bazel 8.

    # Required for rules_closure
    common --enable_workspace
    common --noincompatible_disallow_struct_provider_syntax

    Copy link
    Contributor

    qodo-merge-pro bot commented Mar 26, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Remove duplicate version line

    Remove the duplicate version line. The file should only contain a single version
    number, but currently it has both 8.1.1 and 7.4.1.

    .bazelversion [1-2]

     +8.1.1
    - 7.4.1

    [To ensure code accuracy, apply this suggestion manually]

    Suggestion importance[1-10]: 10

    __

    Why: The suggestion correctly identifies a critical issue where the .bazelversion file contains both the new version (8.1.1) and the old version (7.4.1). This file should only contain a single version number, and having both would cause build failures or unpredictable behavior.

    High
    • Update

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants