-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[rb] ensure driver process is always stopped #15635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
CI Feedback 🧐(Feedback updated until commit 1faeb8b)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
User description
🔗 Related Issues
one part of #15634
💥 What does this PR do?
🔧 Implementation Notes
It might be more obvious to duplicate this in each local driver, but I actually like adding the block here because it also removes the array return that I hate anyway.
💡 Additional Considerations
This should be good as is
🔄 Types of changes
PR Type
Bug fix
Description
Refactored
initialize_local_driver
to ensure driver processes are stopped.Moved
service_url
method fromcommon/driver.rb
tocommon/local_driver.rb
.Updated driver initialization for Chrome, Edge, Firefox, IE, and Safari to use a block for error handling.
Added error handling to stop service manager on WebDriver errors.
Changes walkthrough 📝
6 files
Refactored Chrome driver initialization for error handling
Added error handling and moved `service_url` method
Refactored Edge driver initialization for error handling
Refactored Firefox driver initialization for error handling
Refactored IE driver initialization for error handling
Refactored Safari driver initialization for error handling
1 files
Removed `service_url` method from common driver