Skip to content

CI: update matrix #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Andersson007
Copy link
Collaborator

@Andersson007 Andersson007 commented Apr 23, 2025

SUMMARY

stable-2.16 has been created, adding it to the matrix

postgresql_db

A task containing an empty variable fails now

116     lc_collate: "pt_BR{{ locale_latin_suffix }}"

with

with `[ERROR]: Task failed: Module failed: Database query failed: invalid LC_COLLATE locale name: "pt_BRNone"

the var is defined as empty in another file, so Ansible since 2.19 substitutes it with None. In the earlier versions it seems to substitute it with an empty string.

Adding the following for the variable has helped for postgresql_db test target:

- set_fact:
    locale_latin_suffix: "{{ (locale_latin_suffix is not none) | ternary(locale_latin_suffix, '') }}"
postgresql_info

the failures were partly fixed. The following one was reported in ansible/ansible#85036

213       - result.databases is defined
214
215   - name: postgresql_info - test return publication info
        ^ column 5

fatal: [testhost]: FAILED! => {
    "changed": false,
    "msg": "Task failed: Module failed: Key of type 'int' is not JSON serializable by the 'module_legacy_m2c' profile."
}

@Andersson007 Andersson007 requested a review from hunleyd as a code owner April 23, 2025 11:22
@Andersson007 Andersson007 marked this pull request as draft April 23, 2025 11:22
@Andersson007
Copy link
Collaborator Author

(pinging @oraNod here as he asked)

@@ -212,6 +227,13 @@ stages:
- name: RHEL 9.3
test: rhel/9.3

# Keep this until the tests work.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/until/as long/

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreasscherbaum thanks! If you "suggest" the changes i could press the commit button so that they'll be technically counted as your code contributions

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Andersson007 I don't see an option to do that :-(

My suggestion is:

# Keep this as long as the tests work.

# version we test against is 14.
# Keeping testing against 10 and 14 should cover 13.
# When these tests stop working and it's hard to fix
# or when PostgreSQL 13 gets EOL, remove this target.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rephrase this, along the lines of: When the tests stop working, remove this target and update the documentation with the fact.

As long as this is tested and works, the documentation can show that.

@Andersson007
Copy link
Collaborator Author

Folks, fyi, the changes i've made for the _info module (see the commit) are not breaking. the core doesn't implicitly convert keys in return dicts to strings anymore, so we must convert ints to strs explicitly now, see ansible/ansible#85036

@Andersson007 Andersson007 marked this pull request as ready for review April 24, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants