-
Notifications
You must be signed in to change notification settings - Fork 101
CI: update matrix #838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CI: update matrix #838
Conversation
(pinging @oraNod here as he asked) |
@@ -212,6 +227,13 @@ stages: | |||
- name: RHEL 9.3 | |||
test: rhel/9.3 | |||
|
|||
# Keep this until the tests work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/until/as long/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreasscherbaum thanks! If you "suggest" the changes i could press the commit button so that they'll be technically counted as your code contributions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Andersson007 I don't see an option to do that :-(
My suggestion is:
# Keep this as long as the tests work.
# version we test against is 14. | ||
# Keeping testing against 10 and 14 should cover 13. | ||
# When these tests stop working and it's hard to fix | ||
# or when PostgreSQL 13 gets EOL, remove this target. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rephrase this, along the lines of: When the tests stop working, remove this target and update the documentation with the fact.
As long as this is tested and works, the documentation can show that.
Folks, fyi, the changes i've made for the _info module (see the commit) are not breaking. the core doesn't implicitly convert keys in return dicts to strings anymore, so we must convert ints to strs explicitly now, see ansible/ansible#85036 |
SUMMARY
stable-2.16 has been created, adding it to the matrix
postgresql_db
A task containing an empty variable fails now
with
the var is defined as empty in another file, so Ansible since 2.19 substitutes it with
None
. In the earlier versions it seems to substitute it with an empty string.Adding the following for the variable has helped for postgresql_db test target:
postgresql_info
the failures were partly fixed. The following one was reported in ansible/ansible#85036