Cleanup 11apr25 #4086
Open
Cleanup 11apr25 #4086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patch by Blake Eggleston; reviewed by Benedict Elliott Smith, David Capwell for CASSANDRA-17103
Patch by Blake Eggleston; Reviewed by David Capwell & Benedict Elliott Smith for CASSANDRA-18004
Patch by Blake Eggleston; Reviewed by David Capwell and Benedict Elliott Smith for Cassandra-18192
…n merging to mainline patch by David Capwell; reviewed by Caleb Rackliffe for CASSANDRA-18309
…ce RandomSource patch by David Capwell; reviewed by Blake Eggleston for CASSANDRA-18213
patch by Jacek Lewandowski; reviewed by David Capwell and Caleb Rackliffe for CASSANDRA-18302
…cep-15-accord on cep-21-tcm
…ss when TransactionStatement is prepared patch by David Capwell; reviewed by Ariel Weisberg, Caleb Rackliffe for CASSANDRA-18337
…ID_RSP but got ACCORD_SIMPLE_RSP patch by David Capwell; reviewed by Caleb Rackliffe for CASSANDRA-18375
…ition with PreApply where reads and writes are interleaved, causing one of the coordinators to see the writes from the other patch by David Capwell; reviewed by Ariel Weisberg for CASSANDRA-18422
…o a Stage and run directly in the messageing handler patch by David Capwell; reviewed by Ariel Weisberg, Benedict Elliott Smith for CASSANDRA-18364
…rt tests to add custom logic patch by David Capwell; reviewed by Caleb Rackliffe for CASSANDRA-18485
in a durable log before processing by CommandStores patch by Aleksey Yeschenko; reviewed by David Capwell for CASSANDRA-18344
…tion history patch by Benedict; reviewed by Blake Eggleston for CASSANDRA-18523
- removing unnecessary calls to ServerTestUtils.daemonInitialization() in a handful of tests - minor cleanup in Verb and BTreeSet
patch by David Capwell; reviewed by Ariel Weisberg for CASSANDRA-18519
patch by Aleksey Yeschenko; reviewed by Benedic Elliott Smith for CASSANDRA-18561
patch by Aleksey Yeschenko; reviewed by Blake Eggleston for CASSANDRA-18563
Patch by Blake Eggleston and Benedict Elliott Smith; Reviewed by David Capwell for CASSANDRA-17101 CEP-15: Accord TCM integration Patch by Blake Eggleston; Reviewed by David Capwell for CASSANDRA-18444
…ctions that are known to be applied across the cluster) patch by Benedict Elliott Smith; reviewed by Ariel Weisberg, Aleksey Yeschenko, and David Capwell for CASSANDRA-18883 Co-authored-by: Benedict Elliott Smith <[email protected]> Co-authored-by: Ariel Weisberg <[email protected]> Co-authored-by: Aleksey Yeschenko <[email protected]> Co-authored-by: David Capwell <[email protected]>
…ing right away (apache#3575) patch by David Capwell; reviewed by Blake Eggleston for CASSANDRA-18764
apache/cassandra-accord#56 Patch by Ariel Weisberg; Reviewed by David Capwell for CASSANDRA-18779
…ure not to loose the partial deps (apache#3590) patch by David Capwell; reviewed by Aleksey Yeschenko for CASSANDRA-18783
Accord compaction purgers see random slices of Accord state during compaction (based on randomly selected compaction inputs). For at least the `durability` column in the `commands` table the tombstone being created when truncating was deleting the latest value since we can get enough information to truncate without actuall yhaving the latest `durability` value. To fix we can wait to emit a tombstone until we are erasing the entire command row when truncating or truncating with outcome and meanwhile we can drop the extra columns that are no longer needed instead of using a tombstone. We don't need to emit cell tombstones we can drop them from the purger when processing each row. patch by Ariel Weisberg; reviewed by David Capwell for CASSANDRA-18795
…s nullable but C* serializer doesn't expect null
…s in TxnWrite, as they can simply be pulled from PartialTxn when needed in Write#apply() - Avoid serializing full TxnData instances to Accord state tables patch by Caleb Rackliffe; reviewed by David Capwell, Benedict Elliot Smith, and Ariel Weisberg for CASSANDRA-18355
patch by Aleksey Yeschenko; reviewed by Ariel Weisberg for CASSANDRA-18573
…, SeedDefiner, RunStartDefiner, and Config
…a NPE patch by David Capwell; reviewed by Benedict Elliott Smith for CASSANDRA-20417
Patch by Alex Petrov; reviewed by Benedict Elliott Smith CASSANDRA-20347.
Patch by Alex Petrov; reviewed by Benedict Elliott Smith for CASSANDRA-20424.
… required topology changes patch by David Capwell; reviewed by Benedict Elliott Smith for CASSANDRA-20426
- Decouple command serialization from TableMetadata version; introduce ColumnMetadata ids; gracefully handle missing TableId - DataInputPlus.readLeastSignificantBytes must truncate high bits - Fix RandomPartitioner accord serialization - Fast path stable commits must not override recovery propose/commit decisions regarding visibility of a transaction - RejectBefore must mergeMax, not merge, to ensure we maintain epoch and hlc increasing independently - Bad commitInvalidate decision - consistent filtering for touches and stillTouches - ensure TRUNCATE_BEFORE implies SHARD_APPLIED - TopologyManager.unsyncedOnly off-by-one error - DurabilityQueue should not retry SyncPointErased - handle rare case of no deps but none needed - not updating CFK synchronously on recovery, which can lead to erroneous recovery decisions for other transactions - Don't return partial read response when one commandStore rejects the commit - Filter touches/stillTouches consistently - WaitingState computeLowEpoch must use hasTouched to handle historic key with no route Improve: - Use format parameters to defer building Invariants.requireArgument string - streamline RedundantStatus/RedundantBefore
Patch by Alex Petrov; reviewed by Benedict Elliott Smith for CASSANDRA-20114
…e changes without impacting C* messaging patch by David Capwell; reviewed by Aleksey Yeschenko, Alex Petrov for CASSANDRA-20403
- Accord Journal purging was disabled - remove unique_id from schema keyspace - avoid String.format in Compactor hot path - avoid string concatenation on hot path; improve segment compactor partition build efficiency - Partial compaction should update records in place to ensure truncation of discontiguous compactions do not lead to an incorrect field version being used - StoreParticipants.touches behaviour for RX was erroneously modified; should touch all non-redundant ranges including those no longer owned - SetShardDurable should correctly set DurableBefore Majority/Universal based on the Durability parameter - fix erroneous prunedBefore invariant - Journal compaction should not rewrite fields shadowed by a newer record - Don't save updates to ERASED commands - Simplify CommandChange.getFlags - fix handling of Durability for Invalidated - Don't use ApplyAt for GC_BEFORE with partial input, as might be a saveStatus >= ApplyAtKnown but with executeAt < ApplyAtKnown patch by Benedict; reviewed by Alex Petrov for CASSANDRA-20441
* Fix short accord simulation test (seed 0x6bea128ae851724b), ConcurrentModificationException * Increase wait time during closing to avoid Unterminated threads * Increase timeouts, improve test stability * More descriptive output from CQL test * Shorten max CMS delay * Improve future handling in config service Patch by Alex Petrov; reviewed by Benedict Elliott Smith for CASSANDRA-20440
…YNC mode patch by Benedict; reviewed by David Capwell for CASSANDRA-20521
patch by Benedict; reviewed by David Capwell for CASSANDRA-20529
…p-15-accord patch by David Capwell; reviewed by Caleb Rackliffe for CASSANDRA-20535
Improve: - InMemoryJournal compaction should simulate files to ensure we compact the same cohorts of records (so shadowing applied correctly) - Don't update CFK deps if already known - avoid unnecessary heapification of LogGroupTimers - begin removal of Guava (mostly unused) - consider medium path on fast path delayed - add Seekables.indexOf to support faster serialization - unboxed Invariant.requires variant - AsyncChains.addCallback -> invoke Fix: - Recovery must wait for earlier transactions on shards that have not yet been accepted, even if we recover a fast Stable record on another shard - only skip Dep calculation on PreAccept if vote is required by coordinator - ReadTracker must slice Minimal the first unavailable collection - If PreLoadContext cannot acquire shared caches, still consider existing contents - CFK: make sure to insert UNSTABLE into missing array - Fix failed task stops DelayedCommandStore task queue processing further tasks - short circuit AbstractRanges.equals() - Handle edge case where we can take fast/medium path but one of the Deps replies contains a future TxnId - update executeAtEpoch when retryInFutureEpoch - Fix incorrect validation in validateMissing (should only validate newInfo is not in missing when in witnessedBy; all other additions should be included) patch by Benedict; reviewed by David Capwell for CASSANDRA-20522
patch by David Capwell; reviewed by Benedict Elliott Smith for CASSANDRA-20543
* avoid running python3-dependent tasks when running simulator tasks * fix a problem with simulated snitch rebase * add a distinction between short-lived daemon threads and infinite loop ones for cases when we need to simulate user-implemented infinite loops Patch by Alex Petrov; reviewed by Benedict Elliott Smith for CASSANDRA-20542
Also improve: - TxnId serialization - StoreParticipants serialization - compareUnsigned Node.Id for consistency with serialized TxnId patch by Benedict; reviewed by Alex Petrov for CASSANDRA-20546
patch by David Capwell; reviewed by Ariel Weisberg for CASSANDRA-20549
|
+1 from reviewing https://github.com/belliottsmith/cassandra/compare/serializer-improvements..cleanup-11apr25 This PR is against trunk so don't want to directly approve in GH, but compared to the parent branch for this i am +1 |
belliottsmith
force-pushed
the
cleanup-11apr25
branch
from
e5bfe36 to
d1d7442
Compare
|
after rebasing back on the serializer branch https://github.com/belliottsmith/cassandra/compare/serializer-improvements..cleanup-11apr25 looks good to me; +1 again |
belliottsmith
force-pushed
the
cleanup-11apr25
branch
from
a63deac to
c5ab8be
Compare
patch by David Capwell; reviewed by Benedict Elliott Smith for CASSANDRA-20553
patch by David Capwell; reviewed by Ariel Weisberg for CASSANDRA-20548
patch by Alex Petrov; reviewed by Benedict Elliott Smith, David Capwell for CASSANDRA-20552
belliottsmith
force-pushed
the
cleanup-11apr25
branch
from
c5ab8be to
1e5ee9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for sending a pull request! Here are some tips if you're new here:
Commit messages should follow the following format:
The Cassandra Jira